From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7C4C433F5 for ; Fri, 10 Sep 2021 16:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70739611CC for ; Fri, 10 Sep 2021 16:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229486AbhIJQ3Y (ORCPT ); Fri, 10 Sep 2021 12:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhIJQ3X (ORCPT ); Fri, 10 Sep 2021 12:29:23 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D89AC061574; Fri, 10 Sep 2021 09:28:12 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id w144so3610728oie.13; Fri, 10 Sep 2021 09:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8G7cvQswihFWAazcGsIyLUOsBBl0E9MiiAh80yrTnGw=; b=KPU2Q4wSB9SzEp4o1d0Kw8OTn60RUAozaxLOAq60CTuCjrXULRuI/IAf5ZkF5xvYPJ QHBk7dWDPpOotULVBBiHAgKTHfCDaDi4KPXh1qw06pv2Zyp/BiEQ99RROXdeHcpk5/bh Tt4ZRYV60YkmsbiuI4ZQq9OzXssUB58HzpjlnNK0A9Nk6kpGPFVK9F6V6lcRbxmNElX+ 7mBW5K/pizRrpmmRsEg+iPCgvN3hTcptvmCdCz7TBPB301DZ0h42ArRK86zDaKmoec1g Ohr8mD7BrRMydZuCtbF8JNuXgZj1kLWTiqSF6EU33gvax0RVVpS3KMOmU7Z8V2wdiiFp Ho5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8G7cvQswihFWAazcGsIyLUOsBBl0E9MiiAh80yrTnGw=; b=1MADpFClL/xf20gq9RPtRmpwZ+5BSid4O4Kke5mpYF17DBOIQif6gS0b17hcSz2Urx KTeDyGGRq3n2iuXeLzD1JUILxi25QHMAAjKmHEkoJfZAWLr+UDamKjU63hs08r4qC+2+ wX6FLKLutmWevRITWvyk1r5IuMSVCW5nz+0xO8p616rTDukpbMLdOeCykue0KsTENYH6 FVbVhq77APFasSqkFJieieqSJlda1mtza7MCzQgcy2u5GnK9RrvdJ889oODBOoASgw0M FZVHBmlD+s5d3Ik5sB7bdvffNGxdFsmczZsMIciGULJW5CxxRSHlM05pNcKemqD5D5IL kyYQ== X-Gm-Message-State: AOAM533PfK/OnXKgkfsdMFCwltPbEgxWF9YaMOOSsLv4QMuj8sryYizu NI4vda1LGrC/hfFXcPIpYRY= X-Google-Smtp-Source: ABdhPJwKhmGH8Ry9crSHy946O1RDEza5R0WDpHrtJfwT8v3oho8sEzaemJ43fx3K+bzTzER7jj0YLA== X-Received: by 2002:a05:6808:56a:: with SMTP id j10mr4892216oig.79.1631291291473; Fri, 10 Sep 2021 09:28:11 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id v19sm1331738oic.31.2021.09.10.09.28.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Sep 2021 09:28:11 -0700 (PDT) Subject: Re: [PATCH v2 06/15] leds: trigger: blkdev: Add function to get gendisk by name To: Greg KH Cc: axboe@kernel.dk, pavel@ucw.cz, linux-leds@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kabel@kernel.org References: <20210909222513.2184795-1-arequipeno@gmail.com> <20210909222513.2184795-7-arequipeno@gmail.com> From: Ian Pilcher Message-ID: <4a69b13f-6f7e-98ba-7b9b-35bde571462e@gmail.com> Date: Fri, 10 Sep 2021 11:28:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 9/10/21 1:45 AM, Greg KH wrote: > On Thu, Sep 09, 2021 at 05:25:04PM -0500, Ian Pilcher wrote: >> +/* Must be built-in to access block_class */ >> +struct gendisk *ledtrig_blkdev_get_disk(const char *const name) >> +{ >> + struct device *dev; >> + >> + dev = class_find_device(&block_class, NULL, name, blkdev_match_name); >> + if (dev == NULL) >> + return NULL; > > You now have bumped the reference count on this structure. Where do you > decrement it when you are finished with it? With context this time. Sorry about that. That happens when I "unlink" the block device from the LED in blkdev_disk_unlink_locked() at ledtrig-blkdev.c:410. (And also in the error path of link_device_store() at ledtrig-blkdev.c:372.) -- ======================================================================== In Soviet Russia, Google searches you! ========================================================================