From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shli@kernel.org>, linux-block@vger.kernel.org
Cc: vgoyal@redhat.com, tj@kernel.org, Kernel-team@fb.com,
Shaohua Li <shli@fb.com>, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH V2 1/3] blk-stat: delete useless code
Date: Tue, 10 Oct 2017 12:02:42 -0600 [thread overview]
Message-ID: <4b4db306-01a3-a138-26dd-38133703a8c3@kernel.dk> (raw)
In-Reply-To: <74821887899a7d05c6429e03f0dc49a079c446b9.1507337347.git.shli@fb.com>
On 10/06/2017 06:55 PM, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
>
> Fix two issues:
> - the per-cpu stat flush is unnecessary, nobody uses per-cpu stat except
> sum it to global stat. We can do the calculation there. The flush just
> wastes cpu time.
> - some fields are signed int/s64. I don't see the point.
Anecdotal, I had issues with the div yielding wrong results with
an unsigned type. But I don't remember what or why right now,
unfortunately, and this was before it was merged...
--
Jens Axboe
next prev parent reply other threads:[~2017-10-10 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 0:55 [PATCH V2 0/3] block: export latency info for cgroups Shaohua Li
2017-10-07 0:55 ` [PATCH V2 1/3] blk-stat: delete useless code Shaohua Li
2017-10-10 17:57 ` Omar Sandoval
2017-10-10 18:02 ` Jens Axboe [this message]
2017-10-07 0:56 ` [PATCH V2 2/3] block: set request_list for request Shaohua Li
2017-10-10 19:47 ` Jens Axboe
2017-10-07 0:56 ` [PATCH V2 3/3] blockcg: export latency info for each cgroup Shaohua Li
2017-10-10 17:35 ` weiping zhang
2017-10-10 18:23 ` Shaohua Li
2017-10-11 14:41 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4db306-01a3-a138-26dd-38133703a8c3@kernel.dk \
--to=axboe@kernel.dk \
--cc=Kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=shli@fb.com \
--cc=shli@kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox