Re: [PATCH v4] block: get wp_offset by bdev_offset_from_zone_start

[Bart Van Assche <bvanassche@acm.org>]

On 11/6/24 6:04 PM, LongPing Wei wrote:
> Call bdev_offset_from_zone_start() instead of open-coding it.
> 
> Fixes: dd291d77cc90 ("block: Introduce zone write plugging")
> Signed-off-by: LongPing Wei <weilongping@oppo.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> v4: update commit message
> ---
>   block/blk-zoned.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index af19296fa50d..77a448952bbd 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -537,7 +537,7 @@ static struct blk_zone_wplug *disk_get_and_lock_zone_wplug(struct gendisk *disk,
>   	spin_lock_init(&zwplug->lock);
>   	zwplug->flags = 0;
>   	zwplug->zone_no = zno;
> -	zwplug->wp_offset = sector & (disk->queue->limits.chunk_sectors - 1);
> +	zwplug->wp_offset = bdev_offset_from_zone_start(disk->part0, sector);
>   	bio_list_init(&zwplug->bio_list);
>   	INIT_WORK(&zwplug->bio_work, blk_zone_wplug_bio_work);
>   	zwplug->disk = disk;

Hi LongPing Wei,

Since this patch has not yet been merged, how about reposting it?

Thanks,

Bart.