From: Jens Axboe <axboe@kernel.dk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wander Costa <wcosta@redhat.com>,
Wander Lairson Costa <wander@redhat.com>,
open list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH v5 1/1] blktrace: switch trace spinlock to a raw spinlock
Date: Mon, 20 Dec 2021 16:45:57 -0700 [thread overview]
Message-ID: <4d110c2a-2e70-8fc1-a16e-cd576c646a39@kernel.dk> (raw)
In-Reply-To: <20211220183046.7193720d@rorschach.local.home>
On 12/20/21 4:30 PM, Steven Rostedt wrote:
> On Mon, 20 Dec 2021 13:49:47 -0700
> Jens Axboe <axboe@kernel.dk> wrote:
>
>> Alright, fair enough, mistakes happen. I think the patch looks fine, my
>> main dislike is that it's Yet Another things that needs special RT
>> handling. But I guess that's how it is...
>
> It's not really "yet another thing". That's because in general tracing
> needs special RT handling (and a lot of other special handling, not
> just RT). blktrace falls under the tracing category, and this just
> falls under one more thing to make tracing work with RT.
This isn't the first patch like this I've applied. I'm not saying this
is an issue with tracing, just that it's another one of these "spinlocks
are now preemptible/sleeping with RT" and that necessitates changes like
this.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-20 23:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 19:28 [PATCH v5 1/1] blktrace: switch trace spinlock to a raw spinlock Wander Lairson Costa
2021-12-20 19:38 ` Jens Axboe
2021-12-20 19:49 ` Wander Costa
2021-12-20 20:24 ` Jens Axboe
2021-12-20 20:34 ` Wander Costa
2021-12-20 20:37 ` Jens Axboe
2021-12-20 20:43 ` Wander Costa
2021-12-20 20:49 ` Jens Axboe
2021-12-20 23:30 ` Steven Rostedt
2021-12-20 23:45 ` Jens Axboe [this message]
2021-12-20 20:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d110c2a-2e70-8fc1-a16e-cd576c646a39@kernel.dk \
--to=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
--cc=wcosta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox