From: Pavel Begunkov <asml.silence@gmail.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split
Date: Mon, 11 Jan 2021 04:41:10 +0000 [thread overview]
Message-ID: <4d3593be-8bc8-07bc-632d-94a643f7815d@gmail.com> (raw)
In-Reply-To: <20210111030557.4154161-3-ming.lei@redhat.com>
On 11/01/2021 03:05, Ming Lei wrote:
> q->bio_split is only used by bio_split() for fast cloning bio, and no
> need to allocate bvecs, so remove this flag.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
Tested-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> block/blk-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 7663a9b94b80..00d415be74e6 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -531,7 +531,7 @@ struct request_queue *blk_alloc_queue(int node_id)
> if (q->id < 0)
> goto fail_q;
>
> - ret = bioset_init(&q->bio_split, BIO_POOL_SIZE, 0, BIOSET_NEED_BVECS);
> + ret = bioset_init(&q->bio_split, BIO_POOL_SIZE, 0, 0);
> if (ret)
> goto fail_id;
>
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-01-11 4:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 3:05 [PATCH V3 0/6] block: improvement on bioset & bvec allocation Ming Lei
2021-01-11 3:05 ` [PATCH V3 1/6] block: manage bio slab cache by xarray Ming Lei
2021-01-11 4:39 ` Pavel Begunkov
2021-01-11 6:57 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split Ming Lei
2021-01-11 4:41 ` Pavel Begunkov [this message]
2021-01-11 6:57 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs Ming Lei
2021-01-11 4:41 ` Pavel Begunkov
2021-01-11 6:58 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 4/6] block: set .bi_max_vecs as actual allocated vector number Ming Lei
2021-01-11 4:42 ` Pavel Begunkov
2021-01-11 6:59 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 5/6] block: move three bvec helpers declaration into private helper Ming Lei
2021-01-11 4:42 ` Pavel Begunkov
2021-01-11 7:00 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set' Ming Lei
2021-01-11 3:54 ` Coly Li
2021-01-11 7:00 ` Hannes Reinecke
2021-01-11 4:35 ` [PATCH V3 0/6] block: improvement on bioset & bvec allocation Pavel Begunkov
2021-01-25 2:27 ` Ming Lei
2021-01-25 4:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d3593be-8bc8-07bc-632d-94a643f7815d@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox