From: Coly Li <i@coly.li>
To: Jens Axboe <axboe@kernel.dk>
Cc: Michael Lyle <mlyle@lyle.org>,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/1] bcache: use llist_for_each_entry_safe() in __closure_wake_up()
Date: Thu, 28 Sep 2017 08:46:04 +0800 [thread overview]
Message-ID: <4d5dbd25-e1f3-9dc1-1124-26ba9bd7d8c1@coly.li> (raw)
In-Reply-To: <90e74638-c396-a04f-da5c-72ae387f677d@kernel.dk>
On 2017/9/28 上午4:52, Jens Axboe wrote:
> On 09/27/2017 10:48 PM, Michael Lyle wrote:
>> Jens--
>>
>> I think it's a race condition-- the individual closures remain valid.
>> It's just that the list element has different meanings-- it's either a
>> list actively being used to wake, or a linkage on one of several lists
>> that is being used to await wake. If a closure goes back to wait very
>> quickly after being woken, it can end up connecting its new wait-list
>> with the being-woken list.
>
> Reading it a second time, looks like you are right. OK, then let's just
> queue it up as-is, I'll add the Fixes line this time.
>
Hi Jens,
Copied, next time for similar situation, Fixes will be there.
Thanks for doing this.
--
Coly Li
next prev parent reply other threads:[~2017-09-28 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:54 [PATCH 0/1] bcache fix for 4.14-rc4 Coly Li
2017-09-26 9:54 ` [PATCH 1/1] bcache: use llist_for_each_entry_safe() in __closure_wake_up() Coly Li
2017-09-27 19:16 ` Coly Li
2017-09-27 20:27 ` Jens Axboe
2017-09-27 20:48 ` Michael Lyle
2017-09-27 20:52 ` Jens Axboe
2017-09-28 0:46 ` Coly Li [this message]
2017-09-27 20:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5dbd25-e1f3-9dc1-1124-26ba9bd7d8c1@coly.li \
--to=i@coly.li \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox