From: John Garry <john.g.garry@oracle.com>
To: Yao Sang <sangyao@kylinos.cn>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 4/4] block, nvme: use lower-level limit helpers for namespace heads
Date: Tue, 18 Aug 2026 08:52:10 +0100 [thread overview]
Message-ID: <4d8f9b7d-339a-49c5-9670-0ddd36d7d203@oracle.com> (raw)
In-Reply-To: <20260806024658.4193386-5-sangyao@kylinos.cn>
On 06/08/2026 03:46, Yao Sang wrote:
> Refresh logical_block_size, physical_block_size, io_min, io_opt,
> discard_granularity, zone_write_granularity and the write stream limits
> from the namespace that was just scanned. Keep chunk_sectors conservative
> for non-zoned namespaces because NVME_QUIRK_STRIPE_SIZE can make it
> controller-specific, while zoned namespaces refresh the zone size directly.
I assumed that in this series we would make the change to avoid updating
fixed limits per-path, like logical block size, since that should always
be consistent (per path). However, that does not look to be the case. We
always call nvme_update_ns_head_limits() ->
nvme_apply_ns_head_limits(ns_lim) ->
nvme_apply_ns_head_identify_limit(ns_lim)
next prev parent reply other threads:[~2026-08-18 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 2:46 [PATCH v2 0/4] block/nvme: split path limits for namespace heads Yao Sang
2026-08-06 2:46 ` [PATCH v2 1/4] nvme: factor namespace-head queue-limit update Yao Sang
2026-08-17 8:04 ` Christoph Hellwig
2026-08-17 16:32 ` John Garry
2026-08-06 2:46 ` [PATCH v2 2/4] block: factor block size and alignment handling out of blk_stack_limits Yao Sang
2026-08-17 8:05 ` Christoph Hellwig
2026-08-17 17:05 ` John Garry
2026-08-18 13:08 ` Yao Sang
2026-08-06 2:46 ` [PATCH v2 3/4] block: factor out path limit stacking Yao Sang
2026-08-17 8:10 ` Christoph Hellwig
2026-08-18 13:11 ` Yao Sang
2026-08-06 2:46 ` [PATCH v2 4/4] block, nvme: use lower-level limit helpers for namespace heads Yao Sang
2026-08-17 8:13 ` Christoph Hellwig
2026-08-18 13:14 ` Yao Sang
2026-08-18 7:52 ` John Garry [this message]
2026-08-18 13:09 ` Yao Sang
2026-08-10 8:50 ` [PATCH v2 0/4] block/nvme: split path limits " Yao Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8f9b7d-339a-49c5-9670-0ddd36d7d203@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sangyao@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox