From: Sagi Grimberg <sagi@grimberg.me>
To: Chao Leng <lengchao@huawei.com>, Ming Lei <ming.lei@redhat.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
kbusch@kernel.org, axboe@fb.com, hch@lst.de
Subject: Re: [PATCH v2 0/3] reduce quiesce time for lots of name spaces
Date: Tue, 11 Aug 2020 13:53:04 -0700 [thread overview]
Message-ID: <4dbd5fe2-b3df-dec5-81f2-6ff97472f62a@grimberg.me> (raw)
In-Reply-To: <6dc6bb01-5bfd-bf13-f53a-1bc75a6b3991@huawei.com>
>>> About using per_cpu to replace SRCU, I suggest separate discussion.
>>> Can you show the patch? This will make it easier to discuss.
>> https://lore.kernel.org/linux-block/20200728134938.1505467-1-ming.lei@redhat.com/
>>
> Directly replace SRCU with percpu_ref, is not safe.
> This may make quiesce queue wait extra time, in extreme scenario,
> maybe wait for ever.
Agree with Ming that this is not necessarily pressing as this issue
existed in nvme for a long time.
I don't resist to change the locking mechanism, but Ming needs to
provide evidence that this change does not degrade reliability nor
performance. Personally I'd like to see this specific issue solved
first and then do a an infrastructure change.
prev parent reply other threads:[~2020-08-11 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 9:05 [PATCH v2 0/3] reduce quiesce time for lots of name spaces Chao Leng
2020-08-07 13:49 ` Ming Lei
2020-08-07 16:37 ` Sagi Grimberg
2020-08-10 2:17 ` Chao Leng
2020-08-10 3:15 ` Ming Lei
2020-08-11 3:13 ` Chao Leng
2020-08-11 20:53 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dbd5fe2-b3df-dec5-81f2-6ff97472f62a@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox