Re: [PATCH 2/8] block: remove BLK_ZONE_WPLUG_UNHASHED

[Damien Le Moal <dlemoal@kernel.org>]

On 2/23/26 8:48 PM, Hannes Reinecke wrote:
>> @@ -603,14 +595,14 @@ static inline bool disk_should_remove_zone_wplug(struct
>> gendisk *disk,
>>   {
>>       lockdep_assert_held(&zwplug->lock);
>>   -    /* If the zone write plug was already removed, we are done. */
>> -    if (zwplug->flags & BLK_ZONE_WPLUG_UNHASHED)
>> -        return false;
>> -
>>       /* If the zone write plug is still plugged, it cannot be removed. */
>>       if (zwplug->flags & BLK_ZONE_WPLUG_PLUGGED)
>>           return false;
>>   +    /* If the zone write plug was already removed, we have nothing to do. */
>> +    if (hlist_unhashed(&zwplug->node))
>> +        return false;
>> +
>>       /*
>>        * Completions of BIOs with blk_zone_write_plug_bio_endio() may
>>        * happen after handling a request completion with
> The order of the checks have changed here; not sure if that matters,
> but as it stands it's not a 1:1 conversion.
> Maybe move this check up.

Will do.

-- 
Damien Le Moal
Western Digital Research