From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0698D12C803; Mon, 25 Mar 2024 07:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711352552; cv=none; b=Y+2/AhImVefBJ+pB6nKu3ya9ZdamuUaujI/JuACWE6yvmZpnL0CwcRX37Kjgk2hDKuncTtmmzx1jyB0JvuFOx+cscCRsC6NNVe4kPaqHlJJxUBng82Lmkg8n9FsJCnGuRTjh3g7uF8gWlZuWdDkl2I2R8fPzMywwJ3PzXmUdY0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711352552; c=relaxed/simple; bh=PaOjeQTXUXH777uBTd4u+MGPOvH/o5CMLR9zmwwiBA4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pp3e1vbvesJKO/tg6DLvPZOtazew3atXDPWz9aC53utFbhaJdc92y7pDFF6LKkLkyEgivQPItScXJ92WfOfthzajHpUbFrkTXrXy9ocKCTqfeF48WnDYauJ8Cj+K8lEEFUoIMGj9Fx6u5V9Wi2qgqhcYHln31GK8tMsxpacRzRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fdrhBYjw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fdrhBYjw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64E6DC433C7; Mon, 25 Mar 2024 07:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711352551; bh=PaOjeQTXUXH777uBTd4u+MGPOvH/o5CMLR9zmwwiBA4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fdrhBYjw4ZVoAUM+x22ymswLZNuB+SbbktMfqfO2jFo9PIK80AEkOIyExpihGVFWU Odo3YBJ35G4cUg6YhtoN8ytWnhDUpPUsdDIVWr8T20kxA810Z/bM55neRmDF1sfDw+ YiTzYI3rZmD3wwgBQanYwOvtDlVFfkaHkWxgxQ7TSF3Hhe+yunwsn44IlDENTaUgTV 7V46nbOTHgr9oRkGSrJMSO3lZEC41ee5FCIy7NfU9cEAVzPD+Z52f7dPLvJJhjj2+f 282g3aaOZL4fYVw+3cSJK90pPDz01OT3WTZOIYXkzvUhnAy7j3jZP0N+roxy0kuLx7 a5/ZCCphW6ULw== Message-ID: <4f9b30f2-2351-4d58-b368-46c65288aef9@kernel.org> Date: Mon, 25 Mar 2024 16:42:24 +0900 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/23] hptiop: switch to using ->device_configure Content-Language: en-US To: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" Cc: Niklas Cassel , Takashi Sakamoto , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "Juergen E. Fischer" , Xiang Chen , HighPoint Linux Team , Tyrel Datwyler , Brian King , Lee Duncan , Chris Leech , Mike Christie , John Garry , Jason Yan , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Jack Wang , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Greg Kroah-Hartman , Alim Akhtar , Avri Altman , Bart Van Assche , Krzysztof Kozlowski , Alan Stern , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux1394-devel@lists.sourceforge.net, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com, megaraidlinux.pdl@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20240324235448.2039074-1-hch@lst.de> <20240324235448.2039074-15-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20240324235448.2039074-15-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research