From: John Garry <john.g.garry@oracle.com>
To: Sumit Saxena <sumit.saxena@broadcom.com>
Cc: martin.petersen@oracle.com, axboe@kernel.dk,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
mpi3mr-linuxdrv.pdl@broadcom.com,
James Rizzo <james.rizzo@broadcom.com>
Subject: Re: [PATCH v2 1/3] scsi: scan: allocate sdev and starget on the NUMA node of the host adapter
Date: Mon, 27 Apr 2026 09:26:56 +0100 [thread overview]
Message-ID: <4fa5c202-e884-41ce-8160-f3dcc289293f@oracle.com> (raw)
In-Reply-To: <CAL2rwxr+7tD1BfxKJCn70wyPT34=sfFMfUNAV63SAW0BxQ-0Ug@mail.gmail.com>
On 24/04/2026 12:33, Sumit Saxena wrote:
>> For the actual shost allocation, we still use kzalloc() in
>> scsi_host_alloc(). However, shost associated device is often a pci
>> device, and we probe pci devices in the same NUMA node it exists, and we
>> try NUMA local allocations by default, so nothing is needed to change
>> for the shost allocation - is this right?
> shost allocation is not an issue, I will drop changes related to it.
But you have not made any changes related shost allocation and I am
questioning why.
Further to what I was saying, even though most shosts are based on PCI
device, not all are and I think that it is worth making this same change
for shost allocation.
> The tests indicate that at times sdev and starget are allocated to
> remote NUMA node.
> So, I will limit these changes to sdev and starget only.
next prev parent reply other threads:[~2026-04-27 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 11:38 [PATCH v2 0/3] scsi/block: NUMA-local scan allocations, shared-tag path cleanup, and SCSI I/O counters Sumit Saxena
2026-04-20 11:38 ` [PATCH v2 1/3] scsi: scan: allocate sdev and starget on the NUMA node of the host adapter Sumit Saxena
2026-04-20 12:10 ` John Garry
2026-04-24 11:33 ` Sumit Saxena
2026-04-27 8:26 ` John Garry [this message]
2026-04-28 7:22 ` Sumit Saxena
2026-04-20 11:38 ` [PATCH v2 2/3] block: drop shared-tag fairness throttling Sumit Saxena
2026-04-20 11:38 ` [PATCH v2 3/3] scsi: use percpu counters for iorequest_cnt and iodone_cnt Sumit Saxena
2026-04-20 16:41 ` Bart Van Assche
2026-04-23 9:40 ` Sumit Saxena
2026-04-21 8:45 ` John Garry
2026-04-24 11:17 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fa5c202-e884-41ce-8160-f3dcc289293f@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=james.rizzo@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox