From: Jens Axboe <axboe@kernel.dk>
To: Liu Song <liusong@linux.alibaba.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: determine in advance whether batch alloc can be performed
Date: Fri, 26 Aug 2022 07:33:31 -0600 [thread overview]
Message-ID: <4fff9af8-90c3-86f9-37c7-75dcd3e95dc0@kernel.dk> (raw)
In-Reply-To: <1661477190-86862-1-git-send-email-liusong@linux.alibaba.com>
On 8/25/22 7:26 PM, Liu Song wrote:
> From: Liu Song <liusong@linux.alibaba.com>
>
> Some conditions for judging whether batch alloc can be performed are
> included in "blk_mq_get_tags", and this function is only used by
> "__blk_mq_alloc_requests_batch".
>
> This patch introduced a helper "can_do_batch_alloc" to prepend the
> judgment condition and avoid unnecessary function calls.
Curious if you saw any differences from this? Or do you just consider
it a cleanup?
--
Jens Axboe
next prev parent reply other threads:[~2022-08-26 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 1:26 [PATCH] blk-mq: determine in advance whether batch alloc can be performed Liu Song
2022-08-26 13:33 ` Jens Axboe [this message]
2022-08-27 13:10 ` Liu Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fff9af8-90c3-86f9-37c7-75dcd3e95dc0@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liusong@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox