Re: [PATCH v3 01/16] rust: str: normalize imports in `str.rs`

[Daniel Almeida <daniel.almeida@collabora.com>]

Hi Andreas,

> On 11 Jul 2025, at 08:43, Andreas Hindborg <a.hindborg@kernel.org> wrote:
> 
> Clean up imports in `str.rs`. This makes future code manipulation more
> manageable.

Here’s another instance of why I think this import syntax is not good.

> 
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> ---
> rust/kernel/str.rs | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index a927db8e079c..488b0e97004e 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -3,10 +3,11 @@
> //! String representations.
> 
> use crate::alloc::{flags::*, AllocError, KVec};
> -use core::fmt::{self, Write};
> -use core::ops::{self, Deref, DerefMut, Index};
> -
> use crate::prelude::*;
> +use core::{
> +    fmt::{self, Write},
> +    ops::{self, Deref, DerefMut, Index},
> +};
> 
> /// Byte string without UTF-8 validity guarantee.
> #[repr(transparent)]
> 
> -- 
> 2.47.2
> 
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>