From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E62C43441 for ; Mon, 26 Nov 2018 06:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23B752082F for ; Mon, 26 Nov 2018 06:45:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23B752082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726248AbeKZRiO (ORCPT ); Mon, 26 Nov 2018 12:38:14 -0500 Received: from foss.arm.com ([217.140.101.70]:51998 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbeKZRiN (ORCPT ); Mon, 26 Nov 2018 12:38:13 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 251CB351D; Sun, 25 Nov 2018 22:45:07 -0800 (PST) Received: from [192.168.0.102] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4AB53F5A0; Sun, 25 Nov 2018 22:45:02 -0800 (PST) Subject: Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE To: Vinod Koul Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-media@vger.kernel.org, iommu@lists.linux-foundation.org, linux-rdma@vger.kernel.org, dmaengine@vger.kernel.org, linux-block@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-alpha@vger.kernel.org, akpm@linux-foundation.org, jiangqi903@gmail.com, hverkuil@xs4all.nl References: <1542966856-12619-1-git-send-email-anshuman.khandual@arm.com> <20181124140554.GG3175@vkoul-mobl.Dlink> From: Anshuman Khandual Message-ID: <5228bcdb-b140-a86a-6c9c-488f1a723353@arm.com> Date: Mon, 26 Nov 2018 12:15:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181124140554.GG3175@vkoul-mobl.Dlink> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/24/2018 07:35 PM, Vinod Koul wrote: > On 23-11-18, 15:24, Anshuman Khandual wrote: > >> --- a/drivers/dma/dmaengine.c >> +++ b/drivers/dma/dmaengine.c >> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all); >> static bool dma_chan_is_local(struct dma_chan *chan, int cpu) >> { >> int node = dev_to_node(chan->device->dev); >> - return node == -1 || cpumask_test_cpu(cpu, cpumask_of_node(node)); >> + return node == NUMA_NO_NODE || >> + cpumask_test_cpu(cpu, cpumask_of_node(node)); >> } > > I do not see dev_to_node being updated first, that returns -1 so I would > prefer to check for -1 unless it return NUMA_NO_NODE Sure will update dev_to_node() to return NUMA_NO_NODE as well.