From: Yu Kuai <hailan@yukuai.org.cn>
To: Christoph Hellwig <hch@infradead.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: colyli@kernel.org, hare@suse.de, dlemoal@kernel.org,
tieren@fnnas.com, axboe@kernel.dk, tj@kernel.org,
josef@toxicpanda.com, song@kernel.org, kmo@daterainc.com,
satyat@google.com, ebiggers@google.com, neil@brown.name,
akpm@linux-foundation.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-raid@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: Re: [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO_ISSUE
Date: Thu, 4 Sep 2025 00:54:21 +0800 [thread overview]
Message-ID: <5378349f-4d00-4d3e-9834-f3ddf2e514cc@yukuai.org.cn> (raw)
In-Reply-To: <aLhBqTrbUWVK4OKy@infradead.org>
Hi,
在 2025/9/3 21:24, Christoph Hellwig 写道:
> On Mon, Sep 01, 2025 at 11:32:07AM +0800, Yu Kuai wrote:
>> static inline void blkcg_bio_issue_init(struct bio *bio)
>> {
>> - bio->issue_time_ns = blk_time_get_ns();
>> + struct request_queue *q = bdev_get_queue(bio->bi_bdev);
>> +
>> + if (test_bit(QUEUE_FLAG_BIO_ISSUE, &q->queue_flags))
>> + bio->issue_time_ns = blk_time_get_ns();
>> }
> Given that this is called on a bio and called from generic code
> and not blk-mq, the flag should in the gendisk and not the queue.
>
ok, will change to disk, and also change set/clear the flag to
enable/disable iolatency.
Thanks,
Kuai
next prev parent reply other threads:[~2025-09-03 16:55 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 3:32 [PATCH RFC v3 00/15] block: fix disordered IO in the case recursive split Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 01/15] block: cleanup bio_issue Yu Kuai
2025-09-01 3:43 ` Damien Le Moal
2025-09-01 6:22 ` Yu Kuai
2025-09-03 13:23 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO_ISSUE Yu Kuai
2025-09-02 17:05 ` Bart Van Assche
2025-09-03 0:54 ` Yu Kuai
2025-09-03 13:24 ` Christoph Hellwig
2025-09-03 16:54 ` Yu Kuai [this message]
2025-09-01 3:32 ` [PATCH RFC v3 03/15] md: fix mssing blktrace bio split events Yu Kuai
2025-09-01 6:30 ` Damien Le Moal
2025-09-01 7:53 ` Yu Kuai
2025-09-03 13:25 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio Yu Kuai
2025-09-01 6:31 ` Damien Le Moal
2025-09-03 13:26 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 05/15] block: factor out a helper bio_submit_split_bioset() Yu Kuai
2025-09-01 6:34 ` Damien Le Moal
2025-09-02 17:12 ` Bart Van Assche
2025-09-03 13:28 ` Christoph Hellwig
2025-09-03 13:28 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset() Yu Kuai
2025-09-01 6:37 ` Damien Le Moal
2025-09-01 7:57 ` Yu Kuai
2025-09-03 13:29 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 07/15] md/raid1: convert " Yu Kuai
2025-09-01 6:43 ` Damien Le Moal
2025-09-01 8:03 ` Yu Kuai
2025-09-03 13:30 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 08/15] md/raid10: add a new r10bio flag R10BIO_Returned Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 09/15] md/raid10: convert read/write to use bio_submit_split_bioset() Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 10/15] md/raid5: convert " Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 11/15] md/md-linear: " Yu Kuai
2025-09-03 17:43 ` Bart Van Assche
2025-09-04 0:50 ` Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 12/15] blk-crypto: " Yu Kuai
2025-09-03 13:31 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 13/15] block: skip unnecessary checks for split bio Yu Kuai
2025-09-03 13:33 ` Christoph Hellwig
2025-09-03 17:00 ` Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 14/15] block: fix disordered IO in the case recursive split Yu Kuai
2025-09-02 17:20 ` Bart Van Assche
2025-09-03 1:00 ` Yu Kuai
2025-09-03 1:12 ` Bart Van Assche
2025-09-03 1:41 ` Yu Kuai
2025-09-03 13:34 ` Christoph Hellwig
2025-09-03 16:59 ` Yu Kuai
2025-09-03 17:52 ` Bart Van Assche
2025-09-01 3:32 ` [PATCH RFC v3 15/15] md/raid0: convert raid0_make_request() to use bio_submit_split_bioset() Yu Kuai
2025-09-01 14:09 ` [PATCH RFC v3 00/15] block: fix disordered IO in the case recursive split Bart Van Assche
2025-09-02 1:50 ` Yu Kuai
2025-09-02 8:04 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5378349f-4d00-4d3e-9834-f3ddf2e514cc@yukuai.org.cn \
--to=hailan@yukuai.org.cn \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=colyli@kernel.org \
--cc=dlemoal@kernel.org \
--cc=ebiggers@google.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=johnny.chenyi@huawei.com \
--cc=josef@toxicpanda.com \
--cc=kmo@daterainc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neil@brown.name \
--cc=satyat@google.com \
--cc=song@kernel.org \
--cc=tieren@fnnas.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).