From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: improve error checking in blkdev_bio_end_io_async()
Date: Tue, 19 Oct 2021 13:11:50 -0600 [thread overview]
Message-ID: <5383f8de-ddd9-2148-799a-7a72011975ac@kernel.dk> (raw)
In-Reply-To: <b813826d-ce9a-c043-2d87-a7275d5df77d@gmail.com>
On 10/19/21 1:06 PM, Pavel Begunkov wrote:
> On 10/19/21 19:59, Jens Axboe wrote:
>> Track the current error status of the dio with DIO_ERROR in the flags,
>> which can then avoid diving into dio->bio for the fast path of not
>> having any errors. This reduces the overhead of the function nicely,
>> which was previously dominated by this seemingly cheap check:
>>
>> 4.55% -1.13% [kernel.vmlinux] [k] blkdev_bio_end_io_async
>
> Jens, something gone wrong here. blkdev_bio_end_io_async() is a
> function from my not yet published branch, the perf here is for it,
> but the patch tackles blkdev_bio_end_io().
Yeah, see followup email...
--
Jens Axboe
prev parent reply other threads:[~2021-10-19 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 18:59 [PATCH] block: improve error checking in blkdev_bio_end_io_async() Jens Axboe
2021-10-19 19:05 ` Jens Axboe
2021-10-19 19:06 ` Pavel Begunkov
2021-10-19 19:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5383f8de-ddd9-2148-799a-7a72011975ac@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox