From: Nilay Shroff <nilay@linux.ibm.com>
To: Bart Van Assche <bvanassche@acm.org>, David Wei <dw@davidwei.uk>,
linux-block@vger.kernel.org, cgroups@vger.kernel.org
Cc: hch@lst.de, hare@suse.de, ming.lei@redhat.com,
dlemoal@kernel.org, axboe@kernel.dk, tj@kernel.org,
josef@toxicpanda.com, gjoyce@ibm.com, lkp@intel.com,
oliver.sang@intel.com
Subject: Re: [REPORT] Possible circular locking dependency on 6.18-rc2 in blkg_conf_open_bdev_frozen+0x80/0xa0
Date: Tue, 28 Oct 2025 18:36:20 +0530 [thread overview]
Message-ID: <544b60be-376c-4891-95a4-361b4a207b8a@linux.ibm.com> (raw)
In-Reply-To: <5c29fa84-3a2c-44be-9842-f0230e7b46dd@acm.org>
On 10/28/25 2:00 AM, Bart Van Assche wrote:
> On 10/23/25 9:54 PM, Nilay Shroff wrote:
>> IMO, we need to make lockdep learn about this differences by assigning separate
>> lockdep key/class for each queue's q->debugfs_mutex to avoid this false positive.
>> As this is another report with the same false-positive lockdep splat, I think we
>> should address this.
>>
>> Any other thoughts or suggestions from others on the list?
>
> Please take a look at lockdep_register_key() and
> lockdep_unregister_key(). I introduced these functions six years ago to
> suppress false positive lockdep complaints like this one.
>
Thanks Bart! I'll send out patch with the above proposed fix.
Thanks,
--Nilay
next prev parent reply other threads:[~2025-10-28 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 21:12 [REPORT] Possible circular locking dependency on 6.18-rc2 in blkg_conf_open_bdev_frozen+0x80/0xa0 David Wei
2025-10-24 4:54 ` Nilay Shroff
2025-10-27 20:30 ` Bart Van Assche
2025-10-28 13:06 ` Nilay Shroff [this message]
2025-10-29 8:25 ` Ming Lei
2025-10-30 5:48 ` Nilay Shroff
2025-10-30 6:26 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544b60be-376c-4891-95a4-361b4a207b8a@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=dw@davidwei.uk \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ming.lei@redhat.com \
--cc=oliver.sang@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox