From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, Tang Yizhou <yizhou.tang@shopee.com>
Cc: hch@lst.de, yukuai@fnnas.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Leon Hwang <leon.huangfu@shopee.com>
Subject: Re: [PATCH v5] block: propagate in_flight to whole disk on partition I/O
Date: Fri, 22 May 2026 08:27:11 -0600 [thread overview]
Message-ID: <55588bd7-aca4-4890-bfb1-c77b6f091674@kernel.dk> (raw)
In-Reply-To: <ahBnKR-IunwxVDzg@kbusch-mbp>
On 5/22/26 8:24 AM, Keith Busch wrote:
> On Fri, May 22, 2026 at 10:16:38PM +0800, Tang Yizhou wrote:
>> @@ -1073,7 +1073,7 @@ void bdev_end_io_acct(struct block_device *bdev, enum req_op op,
>> part_stat_inc(bdev, ios[sgrp]);
>> part_stat_add(bdev, sectors[sgrp], sectors);
>> part_stat_add(bdev, nsecs[sgrp], jiffies_to_nsecs(duration));
>> - part_stat_local_dec(bdev, in_flight[op_is_write(op)]);
>> + bdev_inc_in_flight(bdev, op);
>
> This one should be bdev_dec_in_flight().
Yes, and let's chill the repostings. Send 1 per day, we've up to v5 in a
very short amount of time. Take your time and get it right, and give
people a chance to comment and review before randomly throwing version
N+1 over the wall.
--
Jens Axboe
next prev parent reply other threads:[~2026-05-22 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 14:16 [PATCH v5] block: propagate in_flight to whole disk on partition I/O Tang Yizhou
2026-05-22 14:24 ` Keith Busch
2026-05-22 14:27 ` Jens Axboe [this message]
2026-05-25 2:07 ` Yizhou Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55588bd7-aca4-4890-bfb1-c77b6f091674@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=leon.huangfu@shopee.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yizhou.tang@shopee.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox