From: Jens Axboe <axboe@kernel.dk>
To: Julio Faracco <jfaracco@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: include dd_queued{,_show} into proper BLK_DEBUG_FS guard
Date: Mon, 6 Sep 2021 11:39:52 -0600 [thread overview]
Message-ID: <55ccc07f-154e-a1b4-31c5-dd99c8e7d09d@kernel.dk> (raw)
In-Reply-To: <CAHtYXivVcodcR5b2aYnFvhgAJ7yEr0+jYzPZ+w-JxRRzuWJyfA@mail.gmail.com>
On 9/6/21 11:36 AM, Julio Faracco wrote:
> Thanks Jens.
>
> On Mon, Sep 6, 2021 at 1:44 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 9/6/21 10:38 AM, Julio Faracco wrote:
>>> This commit fixes a compilation issue to an unused function if
>>> BLK_DEBUG_FS setting is not enabled. This usually happens in tiny
>>> kernels with several debug options disabled. For further details,
>>> see the message below:
>>>
>>> ../block/mq-deadline.c:274:12: error: ‘dd_queued’ defined but not used [-Werror=unused-function]
>>> 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
>>> | ^~~~~~~~~
>>> cc1: all warnings being treated as errors
>>
>> This is like the 10th one of these... The patch has been queued up for
>> about a week, if you check linux-next or the block tree. It's going
>> upstream soon, in fact it was already sent in yesterday.
>
> I noticed after seeing the same patch earlier this morning, but it was
> too late to undo.
> Discard my patch, pls.
No worries - fwiw, the fix is upstream now.
--
Jens Axboe
prev parent reply other threads:[~2021-09-06 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 16:38 [PATCH] block: include dd_queued{,_show} into proper BLK_DEBUG_FS guard Julio Faracco
2021-09-06 16:44 ` Jens Axboe
2021-09-06 17:36 ` Julio Faracco
2021-09-06 17:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ccc07f-154e-a1b4-31c5-dd99c8e7d09d@kernel.dk \
--to=axboe@kernel.dk \
--cc=jfaracco@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).