From: Kashyap Desai <kashyap.desai@broadcom.com>
To: Ming Lei <ming.lei@redhat.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Jens Axboe <axboe@fb.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Meelis Roos <mroos@linux.ee>, Don Brace <don.brace@microsemi.com>,
Laurence Oberman <loberman@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Hannes Reinecke <hare@suse.de>,
Artem Bityutskiy <artem.bityutskiy@intel.com>
Subject: RE: [PATCH V5 2/5] scsi: megaraid_sas: fix selection of reply queue
Date: Tue, 13 Mar 2018 22:43:50 +0530 [thread overview]
Message-ID: <560d249dfe93281af03648652d1f3277@mail.gmail.com> (raw)
In-Reply-To: <20180313094243.8710-3-ming.lei@redhat.com>
> -----Original Message-----
> From: Ming Lei [mailto:ming.lei@redhat.com]
> Sent: Tuesday, March 13, 2018 3:13 PM
> To: James Bottomley; Jens Axboe; Martin K . Petersen
> Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; linux-
> block@vger.kernel.org; Meelis Roos; Don Brace; Kashyap Desai; Laurence
> Oberman; Mike Snitzer; Paolo Bonzini; Ming Lei; Hannes Reinecke; James
> Bottomley; Artem Bityutskiy
> Subject: [PATCH V5 2/5] scsi: megaraid_sas: fix selection of reply queue
>
> From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs),
one
> msix vector can be created without any online CPU mapped, then command
> may be queued, and won't be notified after its completion.
>
> This patch setups mapping between cpu and reply queue according to irq
> affinity info retrived by pci_irq_get_affinity(), and uses this info to
choose
> reply queue for queuing one command.
>
> Then the chosen reply queue has to be active, and fixes IO hang caused
by
> using inactive reply queue which doesn't have any online CPU mapped.
>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
> Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
> Cc: Christoph Hellwig <hch@lst.de>,
> Cc: Don Brace <don.brace@microsemi.com>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Laurence Oberman <loberman@redhat.com>
> Cc: Mike Snitzer <snitzer@redhat.com>
> Cc: Meelis Roos <mroos@linux.ee>
> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
> Fixes: 84676c1f21e8 ("genirq/affinity: assign vectors to all possible
CPUs")
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Side note - For a max performance, your below proposed patch/series is
required. Without below patch, performance is going to be dropped due to
fewer reply queues are getting utilized one this particular patch is
included.
genirq/affinity: irq vector spread among online CPUs as far as possible
Acked-by: Kashyap Desai <kashyap.desai@broadcom.com>
Tested-by: Kashyap Desai <kashyap.desai@broadcom.com>
next prev parent reply other threads:[~2018-03-13 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 9:42 [PATCH V5 0/5] SCSI: fix selection of reply(hw) queue Ming Lei
2018-03-13 9:42 ` [PATCH V5 1/5] scsi: hpsa: fix selection of reply queue Ming Lei
2018-03-14 8:57 ` Christoph Hellwig
2018-03-14 15:07 ` Bityutskiy, Artem
2018-03-19 11:48 ` Bityutskiy, Artem
2018-03-19 14:31 ` Jens Axboe
2018-03-19 14:42 ` Artem Bityutskiy
2018-03-19 14:55 ` Kashyap Desai
2018-03-19 15:26 ` Ming Lei
2018-03-20 3:16 ` Martin K. Petersen
2018-03-13 9:42 ` [PATCH V5 2/5] scsi: megaraid_sas: " Ming Lei
2018-03-13 17:13 ` Kashyap Desai [this message]
2018-03-14 8:57 ` Christoph Hellwig
2018-03-14 15:07 ` Artem Bityutskiy
2018-03-13 9:42 ` [PATCH V5 3/5] scsi: introduce force_blk_mq Ming Lei
2018-03-13 9:42 ` [PATCH V5 4/5] scsi: virtio_scsi: fix IO hang caused by irq vector automatic affinity Ming Lei
2018-03-14 8:58 ` Christoph Hellwig
2018-03-13 9:42 ` [PATCH V5 5/5] scsi: virtio_scsi: unify scsi_host_template Ming Lei
2018-03-14 8:58 ` Christoph Hellwig
2018-03-15 3:35 ` [PATCH V5 0/5] SCSI: fix selection of reply(hw) queue Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560d249dfe93281af03648652d1f3277@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=artem.bityutskiy@intel.com \
--cc=axboe@fb.com \
--cc=don.brace@microsemi.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mroos@linux.ee \
--cc=pbonzini@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).