From: Jens Axboe <axboe@kernel.dk>
To: Yangtao Li <tiny.windzz@gmail.com>,
ed.cashin@acm.org, philipp.reisner@linbit.com,
lars.ellenberg@linbit.com, josef@toxicpanda.com,
linux-block@vger.kernel.org, josh.h.morris@us.ibm.com,
pjk1939@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com,
nbd@other.debian.org
Subject: Re: [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro
Date: Sat, 1 Dec 2018 11:10:58 -0700 [thread overview]
Message-ID: <5682c419-9e44-10ed-6a2e-286e6f5c5def@kernel.dk> (raw)
In-Reply-To: <20181201142414.7766-1-tiny.windzz@gmail.com>
On 12/1/18 7:24 AM, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> changes in v2:
> -Modify some function names to avoid compilation errors
The fact that your previous patch didn't even compile doesn't fill me
with a lot of confidence in the amount of diligence and testing
you apply to your patches.
Why would you send something out that you didn't even compile?
--
Jens Axboe
next prev parent reply other threads:[~2018-12-01 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 14:24 [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-12-01 18:10 ` Jens Axboe [this message]
2018-12-01 18:31 ` Frank Lee
2018-12-01 18:38 ` Jens Axboe
2018-12-01 18:58 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5682c419-9e44-10ed-6a2e-286e6f5c5def@kernel.dk \
--to=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=ed.cashin@acm.org \
--cc=josef@toxicpanda.com \
--cc=josh.h.morris@us.ibm.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=philipp.reisner@linbit.com \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox