From: Jens Axboe <axboe@kernel.dk>
To: Alexey Klimov <klimov.linux@gmail.com>, linux-block@vger.kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeff Moyer <jmoyer@redhat.com>, Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH] elevator: remove second argument in elevator_init()
Date: Wed, 30 Mar 2016 18:34:32 -0600 [thread overview]
Message-ID: <56FC7098.1050503@kernel.dk> (raw)
In-Reply-To: <CALW4P++6YkPidw33i5x1zMoC4VvZ6uJT2=E4EZD_WHztsRZxGQ@mail.gmail.com>
On 03/30/2016 05:31 PM, Alexey Klimov wrote:
> Hi all,
>
> On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
>> Alexey Klimov <klimov.linux@gmail.com> writes:
>>
>>> Last user of elevator_init() with non-NULL name as second argument
>>> that supposed to be s390 dasd driver has gone few releases ago.
>>> Drivers rely on elevator_change(), elevator_switch() and friends
>>> for example. Right now elevator_init() is always called as
>>> elevator_init(q, NULL).
>>>
>>> Patch removes passing of second name argument and its usage.
>>>
>>> While we're at it fix following if-check after removed lines. We know
>>> that elevator_type e is initialized by NULL and need to check only
>>> chosen_elevator.
>>>
>>> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
>>
>> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>
>
> what is the status of this patch? Is it that wrong and are there some
> concerns or do I need to resend it?
It looks fine, I'll pick it up for 4.7.
--
Jens Axboe
next prev parent reply other threads:[~2016-03-31 0:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 1:46 [PATCH] elevator: remove second argument in elevator_init() Alexey Klimov
2016-01-27 21:01 ` Jeff Moyer
2016-03-30 23:31 ` Alexey Klimov
2016-03-31 0:34 ` Jens Axboe [this message]
2016-09-27 0:13 ` Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC7098.1050503@kernel.dk \
--to=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=klimov.linux@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).