From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <keith.busch@intel.com>, linux-block@vger.kernel.org
Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>,
Gabriel Krisman Bertazi <krisman@collabora.co.uk>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] blk-mq: Take tagset lock when updaing hw queues
Date: Tue, 30 May 2017 12:32:59 -0600 [thread overview]
Message-ID: <56ed7162-5397-b4dd-14d2-1e017c6b7c33@kernel.dk> (raw)
In-Reply-To: <1496169551-26868-1-git-send-email-keith.busch@intel.com>
On 05/30/2017 12:39 PM, Keith Busch wrote:
> The tagset lock needs to be held when iterating the tag_list, so a
> lockdep assert was added when updating number of hardware queues. The
> drivers calling this API, however, were unaware of the new requirement,
> so are failing the assertion.
>
> This patch takes the lock within the blk-mq function so the drivers do
> not have to be modified in order to be safe.
Thanks Keith, applied for 4.12 with the typo in the subject line fixed
up.
--
Jens Axboe
next prev parent reply other threads:[~2017-05-30 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 18:39 [PATCH] blk-mq: Take tagset lock when updaing hw queues Keith Busch
2017-05-30 18:32 ` Jens Axboe [this message]
2017-05-30 19:52 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ed7162-5397-b4dd-14d2-1e017c6b7c33@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@sandisk.com \
--cc=keith.busch@intel.com \
--cc=krisman@collabora.co.uk \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox