Re: block for-next: zram build error

[Jens Axboe <axboe@fb.com>]

On 02/02/2017 04:40 PM, Bart Van Assche wrote:
> Hello Jens,
> 
> I noticed accidentally that with the for-next branch of the block
> git repository that the zram driver doesn't build anymore:
> 
> 
> $ make M=drivers/block/zram
>   LD      drivers/block/zram/built-in.o
>   CC [M]  drivers/block/zram/zcomp.o
>   CC [M]  drivers/block/zram/zram_drv.o
> drivers/block/zram/zram_drv.c: In function ‘zram_revalidate_disk’:
> drivers/block/zram/zram_drv.c:120:37: error: ‘zram->disk->queue->backing_dev_info’ is a pointer; did you mean to use ‘->’?
>   zram->disk->queue->backing_dev_info.capabilities |=
>                                      ^
>                                      ->
> make[1]: *** [scripts/Makefile.build:294: drivers/block/zram/zram_drv.o] Error 1
> make: *** [Makefile:1490: _module_drivers/block/zram] Error 2
> 
> Compilation exited abnormally with code 2 at Thu Feb  2 15:37:19
> 
> 
> I have not yet tried to figure out which commit broke the build.

Thanks for catching that, Bart. I fixed it here after your report:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.11/next&id=e17354961bb50931ec7b33f59c0713dcf98ac7d2

It's caused by commit:

commit dc3b17cc8bf21307c7e076e7c778d5db756f7871
Author: Jan Kara <jack@suse.cz>
Date:   Thu Feb 2 15:56:50 2017 +0100

    block: Use pointer to backing_dev_info from request_queue

-- 
Jens Axboe