From: Jens Axboe <axboe@kernel.dk>
To: Paolo <paolo.valente@linaro.org>, Jeff Moyer <jmoyer@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH BUGFIX] block: add missing group association in bio_split
Date: Mon, 9 May 2016 08:55:21 -0600 [thread overview]
Message-ID: <5730A4D9.40602@kernel.dk> (raw)
In-Reply-To: <5730A108.1000703@linaro.org>
On 05/09/2016 08:39 AM, Paolo wrote:
> Il 09/05/2016 16:35, Jeff Moyer ha scritto:
>> Jeff Moyer <jmoyer@redhat.com> writes:
>>
>>> Paolo Valente <paolo.valente@linaro.org> writes:
>>>
>>>> @@ -1811,6 +1811,11 @@ struct bio *bio_split(struct bio *bio, int
>>>> sectors,
>>>>
>>>> bio_advance(bio, split->bi_iter.bi_size);
>>>>
>>>> +#ifdef CONFIG_BLK_CGROUP
>>>> + if (bio->bi_css)
>>>> + bio_associate_blkcg(split, bio->bi_css);
>>>> +#endif
>>>> +
>>>> return split;
>>>> }
>>>> EXPORT_SYMBOL(bio_split);
>>>
>>> Get rid of the #ifdefery. This should be just:
>>>
>>> bio_associate_blkcg(split, bio->bi_css);
>>
>> Gah, I see that the bi_css member is only present for CONFIG_BLK_CGROUP.
>> I guess we'll have to live with the ifdef.
>>
>
> We have already tried to remove it, but it seems it would require other
> major changes.
It'd be cleaner to have a
bio_clone_associate_blkcg(split, bio);
or similar, and then hide it in there.
--
Jens Axboe
next prev parent reply other threads:[~2016-05-09 14:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 20:45 [PATCH BUGFIX] block: add missing group association in bio_split Paolo Valente
2016-05-09 14:19 ` Jeff Moyer
2016-05-09 14:35 ` Jeff Moyer
2016-05-09 14:39 ` Paolo
2016-05-09 14:55 ` Jens Axboe [this message]
2016-05-09 14:56 ` Mark Brown
2016-05-09 17:58 ` Jens Axboe
2016-05-10 9:08 ` Paolo Valente
2016-05-10 16:12 ` Jeff Moyer
2016-05-10 17:08 ` Paolo
2016-05-10 20:23 ` [PATCH BUGFIX] block: add missing group association in bio-cloning functions Paolo Valente
2016-05-10 20:44 ` Tejun Heo
2016-05-10 21:02 ` [PATCH BUGFIX V2] " Paolo Valente
2016-05-10 21:03 ` Tejun Heo
2016-05-10 21:34 ` Jeff Moyer
2016-05-10 21:44 ` Paolo
2016-05-10 22:01 ` [PATCH BUGFIX V3] " Paolo Valente
2016-05-11 6:38 ` Nikolay Borisov
2016-05-11 6:43 ` Nikolay Borisov
2016-05-11 9:06 ` Paolo
2016-05-11 9:28 ` [PATCH BUGFIX V4] " Paolo Valente
2016-05-12 15:10 ` Tejun Heo
2016-05-13 20:42 ` Jeff Moyer
2016-06-07 7:09 ` Paolo
2016-07-26 16:14 ` Paolo Valente
2016-07-26 17:01 ` kbuild test robot
2016-07-27 5:22 ` [PATCH BUGFIX V5] " Paolo Valente
2016-07-27 14:45 ` Jens Axboe
2016-05-09 15:20 ` [PATCH BUGFIX] block: add missing group association in bio_split Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5730A4D9.40602@kernel.dk \
--to=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=jmoyer@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).