From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4170C19F2B for ; Mon, 1 Aug 2022 14:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbiHAOFH (ORCPT ); Mon, 1 Aug 2022 10:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbiHAOFG (ORCPT ); Mon, 1 Aug 2022 10:05:06 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 84F1E2B260; Mon, 1 Aug 2022 07:05:05 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBF9DED1; Mon, 1 Aug 2022 07:05:05 -0700 (PDT) Received: from [10.57.10.23] (unknown [10.57.10.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 877DA3F73B; Mon, 1 Aug 2022 07:05:00 -0700 (PDT) Message-ID: <57431a71-a71e-472a-9fb4-7acd4f9534cc@arm.com> Date: Mon, 1 Aug 2022 15:04:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 00/13] DMA Mapping P2PDMA Pages Content-Language: en-GB To: Logan Gunthorpe , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, Stephen Bates , Dan Williams , Jason Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell References: <20220708165104.5005-1-logang@deltatee.com> <20220726112906.GA2169@lst.de> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2022-07-26 16:55, Logan Gunthorpe wrote: > > > On 2022-07-26 05:29, Christoph Hellwig wrote: >> I've applied this to the dma-mapping for-next branch. >> >> I'd have liked a review from Robin, but as he seems to be out and the >> rework was to fit his comments I'd rather have us unblocked before >> the end of the merge window. > > Great thanks! If Robin has some feedback when he gets back I'd be happy > to make a couple more cleanup patches. Indeed I've been taking some (rather overdue) holiday the last couple of weeks, sorry I forgot to take a look at this version beforehand. From a quick skim, nothing stands out as objectionable; thanks for taking my suggestions on board! At some point once this lands I'll have a go at using the new flags to improve iommu-dma bounce buffering, so if I do spot anything else while I'm in there I'm sure could clean it up myself. Cheers, Robin.