Linux block layer
 help / color / mirror / Atom feed
From: David Gow <david@davidgow.net>
To: "Alvin Sun" <alvin.sun@linux.dev>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"Rae Moar" <raemoar63@gmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH v3 7/7] rust: doctest: use vertical import style
Date: Tue, 23 Jun 2026 17:19:04 +0800	[thread overview]
Message-ID: <5748f9ca-e684-42a0-9297-e587b178a47c@davidgow.net> (raw)
In-Reply-To: <20260521-miscdev-use-format-v3-7-56240ca70d0c@linux.dev>

Le 21/05/2026 à 2:57 PM, Alvin Sun a écrit :
> Convert `use` imports to vertical layout for better readability and
> maintainability.
> 
> Signed-off-by: Alvin Sun <alvin.sun@linux.dev>
> ---

Assuming this'll go in via the Rust tree, given there are other changers
to the rustdoc work which will likely go in that way. (But, if we'd
prefer it to go in via kselftest/kunit, that shouldn't be a problem.)

Acked-by: David Gow <david@davidgow.net>

Cheers,
-- David

>  scripts/rustdoc_test_gen.rs | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/rustdoc_test_gen.rs b/scripts/rustdoc_test_gen.rs
> index d61a77219a8c2..ee76e96b41eea 100644
> --- a/scripts/rustdoc_test_gen.rs
> +++ b/scripts/rustdoc_test_gen.rs
> @@ -31,8 +31,15 @@
>  use std::{
>      fs,
>      fs::File,
> -    io::{BufWriter, Read, Write},
> -    path::{Path, PathBuf},
> +    io::{
> +        BufWriter,
> +        Read,
> +        Write, //
> +    },
> +    path::{
> +        Path,
> +        PathBuf, //
> +    }, //
>  };
>  
>  /// Find the real path to the original file based on the `file` portion of the test name.
> 


  parent reply	other threads:[~2026-06-23  9:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  6:57 [PATCH v3 0/7] rust: use vertical import style and remove redundant imports Alvin Sun
2026-05-21  6:57 ` [PATCH v3 1/7] rust: miscdevice: use vertical import style Alvin Sun
2026-05-21  6:57 ` [PATCH v3 2/7] samples: rust_misc_device: " Alvin Sun
2026-05-21  6:57 ` [PATCH v3 3/7] rust: miscdevice: remove redundant imports Alvin Sun
2026-05-21  6:57 ` [PATCH v3 4/7] rust: block: mq: use vertical import style Alvin Sun
2026-05-21  6:57 ` [PATCH v3 5/7] rust: block: mq: remove redundant imports and format Alvin Sun
2026-05-21  6:57 ` [PATCH v3 6/7] rust: block: rnull: use vertical import style Alvin Sun
2026-06-18 10:41   ` Andreas Hindborg
2026-05-21  6:57 ` [PATCH v3 7/7] rust: doctest: " Alvin Sun
2026-05-25 17:49   ` Miguel Ojeda
2026-06-23  9:19   ` David Gow [this message]
2026-05-25 17:51 ` [PATCH v3 0/7] rust: use vertical import style and remove redundant imports Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5748f9ca-e684-42a0-9297-e587b178a47c@davidgow.net \
    --to=david@davidgow.net \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=alvin.sun@linux.dev \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=brendan.higgins@linux.dev \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=raemoar63@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox