From: Sagi Grimberg <sagi@lightbits.io>
To: Ming Lin <mlin@kernel.org>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH 2/2] nvme-rdma: check the number of hw queues mapped
Date: Thu, 9 Jun 2016 14:19:55 +0300 [thread overview]
Message-ID: <575950DB.6080701@lightbits.io> (raw)
In-Reply-To: <1465415292-9416-3-git-send-email-mlin@kernel.org>
This needs documentation in the form of:
/*
* XXX: blk-mq might not map all our hw contexts but this is a must for
* us for fabric connects. So until we can fix blk-mq we check that.
*/
> + hw_queue_mapped = blk_mq_hctx_mapped(ctrl->ctrl.connect_q);
> + if (hw_queue_mapped < ctrl->ctrl.connect_q->nr_hw_queues) {
> + dev_err(ctrl->ctrl.device,
> + "%d hw queues created, but only %d were mapped to sw queues\n",
> + ctrl->ctrl.connect_q->nr_hw_queues,
> + hw_queue_mapped);
> + ret = -EINVAL;
> + goto out_cleanup_connect_q;
> + }
> +
> ret = nvme_rdma_connect_io_queues(ctrl);
> if (ret)
> goto out_cleanup_connect_q;
>
next prev parent reply other threads:[~2016-06-09 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 19:48 [PATCH 0/2] check the number of hw queues mapped to sw queues Ming Lin
2016-06-08 19:48 ` [PATCH 1/2] blk-mq: add a function to return number of hw queues mapped Ming Lin
2016-06-08 19:48 ` [PATCH 2/2] nvme-rdma: check the " Ming Lin
2016-06-09 11:19 ` Sagi Grimberg [this message]
2016-06-09 14:10 ` Christoph Hellwig
2016-06-09 19:47 ` Ming Lin
2016-06-08 22:25 ` [PATCH 0/2] check the number of hw queues mapped to sw queues Keith Busch
2016-06-08 22:47 ` Ming Lin
2016-06-08 23:05 ` Keith Busch
2016-06-09 14:09 ` Christoph Hellwig
2016-06-09 19:43 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575950DB.6080701@lightbits.io \
--to=sagi@lightbits.io \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).