From: Mike Christie <mchristi@redhat.com>
To: Christoph Hellwig <hch@lst.de>, axboe@fb.com
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: better packing for struct request
Date: Thu, 9 Jun 2016 17:43:16 -0500 [thread overview]
Message-ID: <5759F104.8090505@redhat.com> (raw)
In-Reply-To: <1465480836-32093-2-git-send-email-hch@lst.de>
On 06/09/2016 09:00 AM, Christoph Hellwig wrote:
> Keep the 32-bit CPU and cmd_type flags together to avoid holes on 64-bit
> architectures.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/linux/blkdev.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 0c9f879..9746d22 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -96,12 +96,11 @@ struct request {
> struct request_queue *q;
> struct blk_mq_ctx *mq_ctx;
>
> - u64 cmd_flags;
> + int cpu;
> unsigned cmd_type;
> + u64 cmd_flags;
> unsigned long atomic_flags;
>
> - int cpu;
> -
> /* the following two fields are internal, NEVER access directly */
> unsigned int __data_len; /* total data len */
> sector_t __sector; /* sector cursor */
>
Looks ok to me.
Reviewed-by: Mike Christie <mchristi@redhat.com>
next prev parent reply other threads:[~2016-06-09 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 14:00 two small updates for the request op split Christoph Hellwig
2016-06-09 14:00 ` [PATCH 1/2] block: better packing for struct request Christoph Hellwig
2016-06-09 22:43 ` Mike Christie [this message]
2016-06-09 14:00 ` [PATCH 2/2] block: add a separate operation type for secure erase Christoph Hellwig
2016-06-09 22:45 ` Mike Christie
2016-06-10 1:37 ` Martin K. Petersen
2016-06-09 15:52 ` two small updates for the request op split Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759F104.8090505@redhat.com \
--to=mchristi@redhat.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).