From: Jens Axboe <axboe@kernel.dk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.com>,
Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
Long Li <longli@linuxonhyperv.com>
Subject: Re: [PATCH 0/4] irq: fix support for allocating sets of IRQs
Date: Sun, 4 Nov 2018 10:24:53 -0700 [thread overview]
Message-ID: <5787f309-fa34-36df-83be-934a64989583@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.21.1811041259350.3160@nanos.tec.linutronix.de>
On 11/4/18 5:02 AM, Thomas Gleixner wrote:
> Jens,
>
> On Sat, 3 Nov 2018, Jens Axboe wrote:
>
>> On 11/2/18 8:59 AM, Ming Lei wrote:
>>> Hi Jens,
>>>
>>> As I mentioned, there are at least two issues in the patch of '
>>> irq: add support for allocating (and affinitizing) sets of IRQs':
>>>
>>> 1) it is wrong to pass 'mask + usedvec' to irq_build_affinity_masks()
>>>
>>> 2) we should spread all possible CPUs in 2-stage way on each set of IRQs
>>>
>>> The fix isn't trivial, and I introduce two extra patches as preparation,
>>> then the implementation can be more clean.
>>>
>>> The patchset is against mq-maps branch of block tree, feel free to
>>> integrate into the whole patchset of multiple queue maps.
>>
>> Thanks Ming, I ran this through my testing, and I end up with the
>> same maps and affinities for all the cases I cared about. I'm going
>> to drop my initial version, and add the three.
>
> So I assume, that I can pick up Mings series instead.
Yes, let's do that.
> There is another patch pending affecting the irq affinity spreading. Can
> you folks please have a look at it?
>
> https://lkml.kernel.org/r/20181102180248.13583-1-longli@linuxonhyperv.com
I'll give that a look and test. Thanks for the heads-up.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-04 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 14:59 [PATCH 0/4] irq: fix support for allocating sets of IRQs Ming Lei
2018-11-02 14:59 ` [PATCH 1/4] Revert "irq: add support for allocating (and affinitizing) sets of IRQs" Ming Lei
2018-11-02 14:59 ` [PATCH 2/4] irq: move 2-stage irq spread into one helper Ming Lei
2018-11-02 14:59 ` [PATCH 3/4] irq: pass first vector to __irq_build_affinity_masks Ming Lei
2018-11-02 14:59 ` [PATCH 4/4] irq: add support for allocating (and affinitizing) sets of IRQs Ming Lei
2018-11-03 21:21 ` [PATCH 0/4] irq: fix support for allocating " Jens Axboe
2018-11-04 12:02 ` Thomas Gleixner
2018-11-04 17:24 ` Jens Axboe [this message]
2018-11-04 18:39 ` Thomas Gleixner
2018-11-05 11:24 ` Thomas Gleixner
2018-11-06 3:02 ` Jens Axboe
2018-11-05 2:18 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787f309-fa34-36df-83be-934a64989583@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox