From: Mike Christie <mchristi@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, david@fromorbit.com,
minchan@kernel.org, ngupta@vflare.org, vishal.l.verma@intel.com,
axboe@kernel.dk, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/1] mm/block: convert rw_page users to bio op use
Date: Thu, 4 Aug 2016 13:51:44 -0500 [thread overview]
Message-ID: <57A38EC0.2020906@redhat.com> (raw)
In-Reply-To: <20160804184602.GA3128@linux.intel.com>
On 08/04/2016 01:46 PM, Ross Zwisler wrote:
> On Thu, Aug 04, 2016 at 12:17:36PM -0500, Mike Christie wrote:
>> This fixes a regression from
>> 4e1b2d52a80d79296a5d899d73249748dea71a53
>> block, fs, drivers: remove REQ_OP compat defs and related code
>>
>> The rw_page users were not converted to use bio/req ops. As a result
>> bdev_write_page is not passing down REQ_OP_WRITE and the IOs will
>> be sent down as reads.
>>
>> Signed-off-by: Mike Christie <mchristi@redhat.com>
>
> Was the intention for this to fix the xfs.mkfs hang I reported with
> generic/361 + XFS?
The hang when also using loop? If so, you also need Christoph's patches:
http://marc.info/?l=linux-fsdevel&m=147032181909530&w=2
http://marc.info/?l=linux-fsdevel&m=147031989408783&w=2
My patch just fixes rw_page users like brd.
next prev parent reply other threads:[~2016-08-04 18:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 17:17 [PATCH 1/1] mm/block: convert rw_page users to bio op use Mike Christie
2016-08-04 17:50 ` kbuild test robot
2016-08-04 19:27 ` Jens Axboe
2016-08-04 19:59 ` Mike Christie
2016-08-04 20:15 ` Jens Axboe
2016-08-04 21:24 ` Mike Christie
2016-08-04 21:26 ` Jens Axboe
2016-08-05 2:18 ` Dave Chinner
2016-08-05 3:30 ` Mike Christie
2016-08-05 7:53 ` Christoph Hellwig
2016-08-04 18:46 ` Ross Zwisler
2016-08-04 18:51 ` Mike Christie [this message]
2016-08-05 7:57 ` Christoph Hellwig
2016-08-05 13:52 ` Jens Axboe
2016-08-05 14:09 ` Jens Axboe
2016-08-05 18:05 ` Mike Christie
2016-08-05 21:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A38EC0.2020906@redhat.com \
--to=mchristi@redhat.com \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=ross.zwisler@linux.intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).