From: Bart Van Assche <bvanassche@acm.org>
To: Julia Suvorova <jusual@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Stefan Hajnoczi <stefanha@gmail.com>,
Aarushi Mehta <mehta.aaru20@gmail.com>
Subject: Re: [PATCH] liburing/barrier.h: Add prefix io_uring to barriers
Date: Mon, 12 Aug 2019 06:55:48 -0700 [thread overview]
Message-ID: <592fe38c-1fa2-9ba5-cd6c-da69c95edb33@acm.org> (raw)
In-Reply-To: <20190812123933.24814-1-jusual@redhat.com>
On 8/12/19 5:39 AM, Julia Suvorova wrote:
> -#define mb() asm volatile("mfence" ::: "memory")
> -#define rmb() asm volatile("lfence" ::: "memory")
> -#define wmb() asm volatile("sfence" ::: "memory")
> -#define smp_rmb() barrier()
> -#define smp_wmb() barrier()
> +#define io_uring_mb() asm volatile("mfence" ::: "memory")
> +#define io_uring_rmb() asm volatile("lfence" ::: "memory")
> +#define io_uring_wmb() asm volatile("sfence" ::: "memory")
> +#define io_uring_smp_rmb() io_uring_barrier()
> +#define io_uring_smp_wmb() io_uring_barrier()
Do users of liburing need these macros? If not, have you considered to
move these macros to a new header file that is only used inside liburing
and such that these macros are no longer visible to liburing users?
Thanks,
Bart.
next prev parent reply other threads:[~2019-08-12 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 12:39 [PATCH] liburing/barrier.h: Add prefix io_uring to barriers Julia Suvorova
2019-08-12 13:40 ` Stefan Hajnoczi
2019-08-12 13:55 ` Bart Van Assche [this message]
2019-08-12 16:03 ` Jens Axboe
2019-08-14 15:23 ` Julia Suvorova
2019-08-16 0:03 ` Hrvoje Zeba
2019-08-19 14:46 ` Jens Axboe
2019-08-20 12:46 ` Julia Suvorova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592fe38c-1fa2-9ba5-cd6c-da69c95edb33@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=jusual@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mehta.aaru20@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox