From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA5AC433EF for ; Sun, 27 Feb 2022 21:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232004AbiB0V6z (ORCPT ); Sun, 27 Feb 2022 16:58:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231997AbiB0V6y (ORCPT ); Sun, 27 Feb 2022 16:58:54 -0500 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E251659E for ; Sun, 27 Feb 2022 13:58:16 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id e6so8415019pgn.2 for ; Sun, 27 Feb 2022 13:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=aXJFJhk1K2hoknGcBZ9kI4Js4QpCOlhkiS6q9yRKYSE=; b=tZknqemS/fPOUC/USDG3GaCA0Nodcy6KelVr8Ar/WafdH7GUSBuJ+lb14p7Z6m6dZP nz46b7PpESAvZaol7cvFRjqGwnw+JLR8tfgC0lDa7HEEuHI403RO7zne3MCaEolcJ+5R UZGsCn9N+2KTKfV/x5ontlHUceiGCb+QRnNC9Ecko0RRkFI3lUb5iud6iaNaexsUVm8T Sq/dX09NFmEwr0PyvXFVfQmjJ6W6if7MGQF7P/D/xZxC+2zvMj3wZsYBvmA1Zz9HTBqq 1HuG2boYwp/XDtUj6wJh/K+hGKU62kPEbzQvopeKHRmxQ+2GgSxXznGhsbQVbS4j80TJ o5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aXJFJhk1K2hoknGcBZ9kI4Js4QpCOlhkiS6q9yRKYSE=; b=4Dit98mwQd9iYRO2PZILcZoLX+Bo/MZISulnNOV1lIFSpsq6nelwLgIIOry2MisQox Pyq7N4yAgbFJAJeTf6dOkfbymoxOdVVGqJKjFbMOBmiIrfHotenSNsen3fFeoZGQdoSa FEQwsD7d6/sb4npzGlcWI0k4tiQjOCKPOIq8UyHQbpzVRH9I/TbqeOBQ/FgyXmPUnFy0 i14eLL4BaZUgn4wRVlkt6v5venxhTaCNqDROQGZcMldrMO0/i66gWXWpwxwdTYwy3d+Z jFyZk2NHcB9tc0Qnprgi1DMugItcH3TWcHp/VZqbLyx6TdPSKpyu1I6GHmwgCRHedYyN 86zw== X-Gm-Message-State: AOAM533tc1Ab/NaEdHVN8URQxhhNUTytyvLyuc2TI0jMotC7A9y27eNH isp4M257NYcJtmRtEWi4EFLktA== X-Google-Smtp-Source: ABdhPJxpRE/n/1CUrpqRACuHUK5ahk4nB13pUI7Ys5UhPY4IircljF5Vov+KiY14lkQ+ra/nf6BogA== X-Received: by 2002:a63:be0e:0:b0:363:e0be:613f with SMTP id l14-20020a63be0e000000b00363e0be613fmr14676330pgf.448.1645999095872; Sun, 27 Feb 2022 13:58:15 -0800 (PST) Received: from [192.168.4.166] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id l5-20020a056a0016c500b004f140564a00sm10716550pfc.203.2022.02.27.13.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 13:58:15 -0800 (PST) Message-ID: <5935986f-bbbf-fa90-2eba-b249ca7e15e1@kernel.dk> Date: Sun, 27 Feb 2022 14:58:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/6] block, fs: assert that key paths use iovecs, and nothing else Content-Language: en-US To: jhubbard.send.patches@gmail.com, Jan Kara , Christoph Hellwig , Dave Chinner , "Darrick J . Wong" , Theodore Ts'o , Alexander Viro , Miklos Szeredi , Andrew Morton , Chaitanya Kulkarni Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, LKML , John Hubbard References: <20220227093434.2889464-1-jhubbard@nvidia.com> <20220227093434.2889464-4-jhubbard@nvidia.com> From: Jens Axboe In-Reply-To: <20220227093434.2889464-4-jhubbard@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > diff --git a/block/bio.c b/block/bio.c > index b15f5466ce08..4679d6539e2d 100644 > --- a/block/bio.c > +++ b/block/bio.c > @@ -1167,6 +1167,8 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) > BUILD_BUG_ON(PAGE_PTRS_PER_BVEC < 2); > pages += entries_left * (PAGE_PTRS_PER_BVEC - 1); > > + WARN_ON_ONCE(!iter_is_iovec(iter)); > + If these make sense, why aren't they also returning an error? -- Jens Axboe