From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 1/5] null_blk: remove the bio based I/O path
Date: Tue, 20 Feb 2024 11:02:46 +0000 [thread overview]
Message-ID: <59c1910e-ff03-4c44-a182-cfef8e6e01ed@oracle.com> (raw)
In-Reply-To: <20240220093248.3290292-2-hch@lst.de>
On 20/02/2024 09:32, Christoph Hellwig wrote:
> Note that the queue_mode field in struct nullb_device is kept as
> that is simpler than having two different places to check the
> value and fully open coding the debugfs helpers as the existing
> ones won't work without a named struct member.
Are nullb.queue_depth and .nr_queues still required? Now they seem to be
just written but never read.
Thanks,
John
next prev parent reply other threads:[~2024-02-20 11:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 9:32 drop bio mode from null_blk and convert it to atomic queue limits v4 Christoph Hellwig
2024-02-20 9:32 ` [PATCH 1/5] null_blk: remove the bio based I/O path Christoph Hellwig
2024-02-20 11:02 ` John Garry [this message]
2024-02-20 9:32 ` [PATCH 2/5] null_blk: initialize the tag_set timeout in null_init_tag_set Christoph Hellwig
2024-02-20 9:32 ` [PATCH 3/5] null_blk: refactor tag_set setup Christoph Hellwig
2024-02-20 9:32 ` [PATCH 4/5] null_blk: remove null_gendisk_register Christoph Hellwig
2024-02-20 9:32 ` [PATCH 5/5] null_blk: pass queue_limits to blk_mq_alloc_disk Christoph Hellwig
2024-02-20 13:22 ` drop bio mode from null_blk and convert it to atomic queue limits v4 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2024-02-20 5:32 drop bio mode from null_blk and convert it to atomic queue limits v3 Christoph Hellwig
2024-02-20 5:32 ` [PATCH 1/5] null_blk: remove the bio based I/O path Christoph Hellwig
2024-02-20 7:21 ` Hannes Reinecke
2024-02-19 6:29 drop bio mode from null_blk and convert it to atomic queue limits v2 Christoph Hellwig
2024-02-19 6:29 ` [PATCH 1/5] null_blk: remove the bio based I/O path Christoph Hellwig
2024-02-14 9:54 drop bio mode from null_blk and convert it to atomic queue limits Christoph Hellwig
2024-02-14 9:54 ` [PATCH 1/5] null_blk: remove the bio based I/O path Christoph Hellwig
2024-02-14 11:25 ` Damien Le Moal
2024-02-14 17:25 ` Keith Busch
2024-02-14 23:16 ` Damien Le Moal
2024-02-14 23:34 ` Keith Busch
2024-02-15 8:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c1910e-ff03-4c44-a182-cfef8e6e01ed@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).