public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: chengming.zhou@linux.dev, axboe@kernel.dk, ming.lei@redhat.com,
	hch@lst.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhouchengming@bytedance.com
Subject: Re: [PATCH 3/4] blk-mq: delete superfluous check in iterate callback
Date: Mon, 21 Aug 2023 14:29:23 -0700	[thread overview]
Message-ID: <59eb0dc2-1f95-1bca-74d2-b6e04826a83f@acm.org> (raw)
In-Reply-To: <20230821073528.3469210-4-chengming.zhou@linux.dev>

On 8/21/23 00:35, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The blk_mq_queue_tag_busy_iter() already has BT_TAG_ITER_STARTED flag
> filter set, only started requests will be iterated over.

Please consider changing the description of this patch into something like
the following: "The previous patch in this series changed the behavior of
blk_mq_queue_tag_busy_iter() from iterating over all allocated tags into
iterating over started requests only. Leave out the code from
blk_mq_rq_inflight() that became superfluous because of this change."

Thanks,

Bart.

  reply	other threads:[~2023-08-21 21:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  7:35 [PATCH 0/4] blk-mq-tag: remove bt_for_each() chengming.zhou
2023-08-21  7:35 ` [PATCH 1/4] blk-mq-tag: support queue filter in bt_tags_iter() chengming.zhou
2023-08-21 19:58   ` Bart Van Assche
2023-08-22  2:21     ` Chengming Zhou
2023-08-21  7:35 ` [PATCH 2/4] blk-mq-tag: remove bt_for_each() chengming.zhou
2023-08-21 21:26   ` Bart Van Assche
2023-08-22  2:27     ` Chengming Zhou
2023-08-21  7:35 ` [PATCH 3/4] blk-mq: delete superfluous check in iterate callback chengming.zhou
2023-08-21 21:29   ` Bart Van Assche [this message]
2023-08-21  7:35 ` [PATCH 4/4] blk-mq-tag: update or fix functions documentation chengming.zhou
2023-08-21 21:32   ` Bart Van Assche
2023-08-22  2:36     ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59eb0dc2-1f95-1bca-74d2-b6e04826a83f@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=chengming.zhou@linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox