From: Wols Lists <antlists@youngman.org.uk>
To: Song Liu <songliubraving@fb.com>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
Song Liu <liu.song.a23@gmail.com>, NeilBrown <neilb@suse.com>
Subject: Re: [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone
Date: Fri, 30 Aug 2019 11:47:24 +0100 [thread overview]
Message-ID: <5D68FEBC.9060709@youngman.org.uk> (raw)
In-Reply-To: <F0E716F8-76EC-4315-933D-A547B52F1D27@fb.com>
On 23/08/19 18:51, Song Liu wrote:
> I guess md_is_broken() should return bool? Otherwise, looks good to me.
Just an outsider's observation - if the function is actually checking
whether a member is missing maybe it should read
broken = md_member_is_missing();
That way the function says what it does, and the assignment says what
you're doing with it.
Cheers,
Wol
next prev parent reply other threads:[~2019-08-30 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 16:13 [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Guilherme G. Piccoli
2019-08-22 16:13 ` [PATCH v3 2/2] mdadm: Introduce new array state 'broken' for raid0/linear Guilherme G. Piccoli
2019-08-22 21:56 ` Song Liu
2019-08-29 12:51 ` Guilherme G. Piccoli
2019-08-30 8:17 ` NeilBrown
2019-08-30 12:48 ` Guilherme G. Piccoli
2019-08-22 21:55 ` [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Song Liu
2019-08-23 17:48 ` Guilherme G. Piccoli
2019-08-23 17:51 ` Song Liu
2019-08-30 10:47 ` Wols Lists [this message]
2019-08-30 11:25 ` Guilherme Piccoli
2019-09-03 19:53 ` Guilherme G. Piccoli
2019-08-30 8:08 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D68FEBC.9060709@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=dm-devel@redhat.com \
--cc=gpiccoli@canonical.com \
--cc=jay.vosburgh@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=neilb@suse.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox