From: Jens Axboe <axboe@kernel.dk>
To: yangerkun <yangerkun@huawei.com>,
ming.lei@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-mq: remove unused code exist in blk_mq_dispatch_rq_list
Date: Fri, 17 Jul 2020 07:26:09 -0600 [thread overview]
Message-ID: <5a2538b5-2883-056c-3928-62a32069baae@kernel.dk> (raw)
In-Reply-To: <20200717092348.36303-1-yangerkun@huawei.com>
On 7/17/20 3:23 AM, yangerkun wrote:
> Once .queue_rq return BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE, we will
> insert the rq back to list, and will return false since '(!list_empty)'
> always be true. The latter check seems unused.
This check is already gone in for-5.9/block
--
Jens Axboe
prev parent reply other threads:[~2020-07-17 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 9:23 [PATCH] blk-mq: remove unused code exist in blk_mq_dispatch_rq_list yangerkun
2020-07-17 10:03 ` Ming Lei
2020-07-17 13:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a2538b5-2883-056c-3928-62a32069baae@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox