Linux block layer
 help / color / mirror / Atom feed
From: Nilay Shroff <nilay@linux.ibm.com>
To: Saravanan D <saravanand@crusoe.ai>, linux-block@vger.kernel.org
Cc: shinichiro.kawasaki@wdc.com, linux-nvme@lists.infradead.org,
	dwagner@suse.de, hare@suse.de, sagi@grimberg.me,
	kbusch@kernel.org, iyamahata@crusoe.ai, kiyer@crusoe.ai,
	ganbalagane@crusoe.ai, sjpark@crusoe.ai, bchen@crusoe.ai
Subject: Re: [PATCH blktests v2] nvme/081: test the per-queue io_cpu sysfs attribute
Date: Wed, 11 Nov 2026 14:17:44 +0530	[thread overview]
Message-ID: <5ac651df-2140-4e56-a8d1-857f599a8046@linux.ibm.com> (raw)
In-Reply-To: <20261110115005.47367-1-saravanand@crusoe.ai>

On 11/10/26 5:20 PM, Saravanan D wrote:
> nvme-tcp exposes/sys/class/nvme/nvmeX/queues/<qid>/io_cpu and managed,
> so a control plane can choose the CPU that runs each I/O queue's socket
> work [1]. Test that
> 
>    - io_cpu reads back a written CPU and rejects invalid values
>    - managed is read only and turns 0 once io_cpu is written
>    - an assignment and the queue directories survive a controller reset
>    - the queue directories follow the queue count as attr_qid_max
>      shrinks and grows it
>    - removing the controller while io_cpu is written completes
> 
> The test skips when the kernel does not have the queues/ directory or
> the io_cpu attribute.
> 
> [1]https://lore.kernel.org/linux-nvme/cover.1794015622.git.saravanand@crusoe.ai/
> 
> Assisted-by: Claude:claude-opus-5-5 [Claude Code]
> Signed-off-by: Saravanan D<saravanand@crusoe.ai>

Looks good to me:

Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>

      reply	other threads:[~2026-11-11  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1794015622.git.saravanand@crusoe.ai>
2026-11-07  9:53 ` [PATCH blktests] nvme/081: test the per-queue io_cpu sysfs attribute Saravanan D
2026-11-09 13:43   ` Nilay Shroff
2026-11-10 11:49     ` Saravanan D
2026-11-10 11:50     ` [PATCH blktests v2] " Saravanan D
2026-11-11  8:47       ` Nilay Shroff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ac651df-2140-4e56-a8d1-857f599a8046@linux.ibm.com \
    --to=nilay@linux.ibm.com \
    --cc=bchen@crusoe.ai \
    --cc=dwagner@suse.de \
    --cc=ganbalagane@crusoe.ai \
    --cc=hare@suse.de \
    --cc=iyamahata@crusoe.ai \
    --cc=kbusch@kernel.org \
    --cc=kiyer@crusoe.ai \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=saravanand@crusoe.ai \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=sjpark@crusoe.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox