From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177D04252D9 for ; Wed, 9 Sep 2026 10:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788948628; cv=none; b=Mzp6JmBuxsL4mHW/tQ0+yWHpxuEcMUJbZhPFzSUo7yjS/M1S1mpOnN1lRHFnpyJa4aIX87g4OqtmVObSMtjeuLKd5oqg6ixuoUXql+3bvyTPs31rEU4ykYzkxzQST+S8CLm8x7ygyo6ecxm6PfbVSCofQw/kb9sz00A9d2zKXqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788948628; c=relaxed/simple; bh=1gndqcwixIf69ERl83wZ/ahlq6SVahr40TbASWBQcgI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=YhuT+A42l+U+pzQ9Agycxj+T9KLYoiiIBWk0VEtyzCvCoYvAR5qISp5dZ2bH7lXj4D6YaQMjZq504VaS7++bXVT41UMyFO6jaG2KjDPiBYFj5yPBXhP+I5D2GppXkQHqQiHevnjI52GeymSSPLahYlZXhjlvTyXBW2ByemMomVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Bgff6UGd; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Bgff6UGd" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-66fcf87897fso4320169d50.3 for ; Wed, 09 Sep 2026 03:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1788948625; x=1789553425; darn=vger.kernel.org; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lsHaeoqxnMhy2GB3rUAu2bzr8hj8izpjrzp8bJJzBnk=; b=Bgff6UGd6F/BxFyng4Kl/LyCtan7qCWYfurAm16dHjBKg/yW/+EtIiHOldFnUPsRy9 LaK3d/O6kMKriCN/VVi/dvv+tdmDyzQJdGzAk+Jue4tQkTS3ABctBnM8dev21qLBxlev UliqiGTMuPygDF7R613arm5jJYiO4tVpEoUWk2V1CSrw94a8RFIqnhttpr4AflIQbk/Z NoGUgHHTEoDXU4DAU7Y81b6VuqZnehJY5C1AIOlh3KQseylO9XxUIpZvO1RpgvWw2TEV qiIrxuhxLDHpL5q+jGjTFzLrMdInp6PfYEz2zvvhYvsDoZ+vtg3xKiP+amY+WOI3s0BC pwrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788948625; x=1789553425; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lsHaeoqxnMhy2GB3rUAu2bzr8hj8izpjrzp8bJJzBnk=; b=aitQc5gWZhg7/5abJBUZbR8uYhmuNsWgJsV3N7O21e+BBWowObtvCviCTN2dCSyP/w tRimgv21iffzWNL9SWTspdTXRJ0GPocDwubRQ2EwbNPQ3+1X/h7TEqRWC/XmP/GfTyJm UyQx4zd1awjnrJ94At+CwrErdVB+zgQM2cF1VhxRVnDmas7rpGocSrbapGDWsDQQaxnv tvfsrttBWsrKTxhQX/Ie7M5l3qWCQMWx8vwRjac2iww6lquELFeAPOHa7MyKC9vDtjOg tmDsR2I8E5Pb3tnzJMUBdJ7AKOdEeEgyLzRv8RF3F2gKtzzu0B0nTm6vqhaYziKhI3/d UTMA== X-Forwarded-Encrypted: i=1; AKwUvByuRz3P+M8kEzi4UajeZQl5T90mCGPIzJ3TXRQSEd17tH1xkhSBgbn+NC6phssvW1NxPOtWrNpmDck7TQ==@vger.kernel.org X-Gm-Message-State: AFuF++kWuNc5DA13S5JgJBVy1D/Kv0IFRkIgGpOQRj/EU1J/L6MZ0Mn8 8ivywrdK4gtbb8odBdazaBSZtxTN95b7H6vlmzAQqAr+kMLIXLxxJlDja6HLEWH5uQ== X-Gm-Gg: AYBFou0CXDKrLXUpqDQPHrr7+ffy7ND+82YxYtoaCpziLyCI2haCZEkMXUnXWWmNdXn 2PmJzeuG2+FjvO/eoroMGsl9D9LZoYq4TtLfGgb9cr5lr8YTHIS+DdrBIGbMOSASXrtaUCfngI4 0mrobmxA/S36mAiN5oVTwNGo2jPgRt67UppZATlBtq3UCzdRgjSLR5LfrNkXxteRsGJTR/mi2Fi 7YSZUOiA6OHi/k3QbxoHGdzJO1dtK5GijjE9iuno0G8/68YJk+LV7G3GeK8rEwuXKzBQQBOivIR 4Qly/YBa4+6KXzepTeTKkjKOpIqJ3AgOnj1IFf6imWVWnlm6B/Wab2eeDwXihMhqnUwBUKbQRYQ oTjB9N7dyBpXtMaqqrzxxipLl0PBCB6QBpx9AktL7LwAFra6xcjXjLG0xS9aLYSOqiUqpH6d1MG mwFXOAFO4WNgTkmakDX9Jd79e/H9neOjTkmYvvao5HIFrhLNhLfUVL89PZWBOZ1e7b0nhSyWteQ +V6Mj1bsx2tbxYluvHLB9HuJHseoslk/QAfygOy+kX7zkKp6Sj01tmN0BA= X-Received: by 2002:a53:ad49:0:b0:66f:c1bc:4095 with SMTP id 956f58d0204a3-66fc1bc4852mr7414444d50.88.1788948624105; Wed, 09 Sep 2026 03:10:24 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66fb48b374bsm12096623d50.3.2026.09.09.03.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 03:10:22 -0700 (PDT) Date: Wed, 9 Sep 2026 03:10:17 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Ackerley Tng , Alexander Viro , Alexandre Ghiti , Baolin Wang , Barry Song , Binbin Wu , Christian Brauner , Christoph Hellwig , Christoph Lameter , Claudio Imbrenda , David Hildenbrand , JP Kobryn , Jan Kara , Jens Axboe , Johannes Weiner , Kairui Song , Kiryl Shutsemau , Lance Yang , Leonardo Bras , Lorenzo Stoakes , Marcelo Tosatti , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michal Hocko , Minchan Kim , Muchun Song , Oscar Salvador , Peter Zijlstra , Qi Zheng , Rik van Riel , Sebastian Andrzej Siewior , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yu Zhao , Zach O'Keefe , Zi Yan , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 14/26] mm/fbatch: no lru_add_drain() nor _all() for memfd_wait_for_pins() In-Reply-To: Message-ID: <5b393933-b097-9d70-be09-2d00c8d62f6b@google.com> References: Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII memfd_tag_pins() used lru_add_drain(), memfd_wait_for_pins() then used lru_add_drain_all(): remove those calls, no longer useful now that the per-cpu fbatch references are gone. Signed-off-by: Hugh Dickins --- mm/memfd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/memfd.c b/mm/memfd.c index c708d92533f4..064f24dcddaa 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -40,8 +40,6 @@ static void memfd_tag_pins(struct xa_state *xas) struct folio *folio; int latency = 0; - lru_add_drain(); - xas_lock_irq(xas); xas_for_each(xas, folio, ULONG_MAX) { if (!xa_is_value(folio) && memfd_folio_has_extra_refs(folio)) @@ -168,9 +166,7 @@ static int memfd_wait_for_pins(struct address_space *mapping) if (!xas_marked(&xas, MEMFD_TAG_PINNED)) break; - if (!scan) - lru_add_drain_all(); - else if (schedule_timeout_killable((HZ << scan) / 200)) + if (scan && schedule_timeout_killable((HZ << scan) / 200)) scan = LAST_SCAN; xas_set(&xas, 0); -- 2.51.0