From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [BUG] io_uring: defer logic based on shared data
Date: Fri, 25 Oct 2019 12:55:25 +0300 [thread overview]
Message-ID: <5badf1c0-9a7d-0950-2943-ff8db33e0929@gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]
I found 2 problems with __io_sequence_defer().
1. it uses @sq_dropped, but doesn't consider @cq_overflow
2. @sq_dropped and @cq_overflow are write-shared with userspace, so
it can be maliciously changed.
see sent liburing test (test/defer *_hung()), which left an unkillable
process for me
--
Yours sincerely,
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2019-10-25 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:55 Pavel Begunkov [this message]
2019-10-25 16:03 ` [BUG] io_uring: defer logic based on shared data Jens Axboe
2019-10-25 16:09 ` Jens Axboe
2019-10-25 16:21 ` Jens Axboe
2019-10-25 16:21 ` Pavel Begunkov
2019-10-25 16:27 ` Jens Axboe
2019-10-25 16:32 ` Jens Axboe
2019-10-25 16:40 ` Pavel Begunkov
2019-10-25 16:44 ` Jens Axboe
2019-10-25 16:55 ` Pavel Begunkov
2019-10-25 16:57 ` Jens Axboe
2019-10-25 18:13 ` Pavel Begunkov
2019-10-25 18:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5badf1c0-9a7d-0950-2943-ff8db33e0929@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox