From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/5] block: have plug stored requests hold references to the queue
Date: Thu, 4 Nov 2021 12:35:22 -0600 [thread overview]
Message-ID: <5c0535f0-253b-1a47-b76c-5d3dfeb2bc4f@kernel.dk> (raw)
In-Reply-To: <YYQnxC65eFMXj3op@infradead.org>
On 11/4/21 12:34 PM, Christoph Hellwig wrote:
> On Thu, Nov 04, 2021 at 12:21:57PM -0600, Jens Axboe wrote:
>> Requests that were stored in the cache deliberately didn't hold an enter
>> reference to the queue, instead we grabbed one every time we pulled a
>> request out of there. That made for awkward logic on freeing the remainder
>> of the cached list, if needed, where we had to artificially raise the
>> queue usage count before each free.
>>
>> Grab references up front for cached plug requests. That's safer, and also
>> more efficient.
>
> I think it would be useful to add zour explanation why the cached
> requests should be flushed at schedule time now here.
>
> Otherwise this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, I'll add a comment when amending with your reviewed-by.
--
Jens Axboe
next prev parent reply other threads:[~2021-11-04 18:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:21 [PATCHSET v3 0/5] Alloc batch fixes Jens Axboe
2021-11-04 18:21 ` [PATCH 1/5] block: have plug stored requests hold references to the queue Jens Axboe
2021-11-04 18:34 ` Christoph Hellwig
2021-11-04 18:35 ` Jens Axboe [this message]
2021-11-04 18:21 ` [PATCH 2/5] block: split request allocation components into helpers Jens Axboe
2021-11-04 18:35 ` Christoph Hellwig
2021-11-04 18:21 ` [PATCH 3/5] block: make blk_try_enter_queue() available for blk-mq Jens Axboe
2021-11-04 18:22 ` [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio() Jens Axboe
2021-11-04 18:36 ` Christoph Hellwig
2021-11-04 18:37 ` Jens Axboe
2021-11-04 18:39 ` Christoph Hellwig
2021-11-04 18:40 ` Jens Axboe
2021-11-04 18:45 ` Jens Axboe
2021-11-04 18:52 ` Christoph Hellwig
2021-11-04 19:02 ` Jens Axboe
2021-11-04 19:04 ` Christoph Hellwig
2021-11-04 19:15 ` Jens Axboe
2021-11-11 12:58 ` Geert Uytterhoeven
2021-11-11 13:19 ` Martin K. Petersen
2021-11-11 14:48 ` Geert Uytterhoeven
2021-11-11 15:36 ` Martin K. Petersen
2021-11-11 21:35 ` Michael Schmitz
2021-11-12 7:37 ` Geert Uytterhoeven
2021-11-12 22:34 ` Michael Schmitz
2021-11-13 7:02 ` Michael Schmitz
2021-11-13 10:06 ` Geert Uytterhoeven
2021-11-13 22:11 ` Michael Schmitz
2021-11-11 13:44 ` Ming Lei
2021-11-11 14:51 ` Geert Uytterhoeven
2021-11-11 15:23 ` Ming Lei
2021-11-11 22:17 ` Jens Axboe
2021-11-12 0:44 ` Ming Lei
2021-11-12 7:51 ` Geert Uytterhoeven
2021-11-15 19:23 ` Michael Schmitz
2021-11-04 18:22 ` [PATCH 5/5] block: ensure cached plug request matches the current queue Jens Axboe
2021-11-04 18:36 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-11-04 15:21 [PATCHSET v2 0/5] Alloc batch fixes Jens Axboe
2021-11-04 15:22 ` [PATCH 1/5] block: have plug stored requests hold references to the queue Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0535f0-253b-1a47-b76c-5d3dfeb2bc4f@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).