Re: [PATCH -next] fs/Kconfig: Fix compile error for romfs

Re: [PATCH -next] fs/Kconfig: Fix compile error for romfs

[Jens Axboe]

On 8/3/23 7:07?AM, Li Zetao wrote:
> There are some compile errors reported by kernel test robot:
> 
> arm-linux-gnueabi-ld: fs/romfs/storage.o: in function `romfs_dev_read':
> storage.c:(.text+0x64): undefined reference to `__brelse'
> arm-linux-gnueabi-ld: storage.c:(.text+0x9c): undefined reference to `__bread_gfp'
> arm-linux-gnueabi-ld: fs/romfs/storage.o: in function `romfs_dev_strnlen':
> storage.c:(.text+0x128): undefined reference to `__brelse'
> arm-linux-gnueabi-ld: storage.c:(.text+0x16c): undefined reference to `__bread_gfp'
> arm-linux-gnueabi-ld: fs/romfs/storage.o: in function `romfs_dev_strcmp':
> storage.c:(.text+0x22c): undefined reference to `__bread_gfp'
> arm-linux-gnueabi-ld: storage.c:(.text+0x27c): undefined reference to `__brelse'
> arm-linux-gnueabi-ld: storage.c:(.text+0x2a8): undefined reference to `__bread_gfp'
> arm-linux-gnueabi-ld: storage.c:(.text+0x2bc): undefined reference to `__brelse'
> arm-linux-gnueabi-ld: storage.c:(.text+0x2d4): undefined reference to `__brelse'
> arm-linux-gnueabi-ld: storage.c:(.text+0x2f4): undefined reference to `__brelse'
> arm-linux-gnueabi-ld: storage.c:(.text+0x304): undefined reference to `__brelse'
> 
> The reason for the problem is that the commit
> "925c86a19bac" ("fs: add CONFIG_BUFFER_HEAD") has added a new config
> "CONFIG_BUFFER_HEAD" that controls building the buffer_head code, and
> romfs needs to use the buffer_head API, but no corresponding config has
> beed added. Select the config "CONFIG_BUFFER_HEAD" in romfs Kconfig to
> resolve the problem.

Patch looks good to me, for some reason not CC'ed to any lists though.
Adding linux-block now and getting it applied.

-- 
Jens Axboe