Re: [PATCH blktests v2 6/9] md/003: add NVMe atomic write tests for stacked devices

[John Garry <john.g.garry@oracle.com>]

On 25/09/2025 09:39, Shinichiro Kawasaki wrote:
>> +	echo "Test complete"
>> +}
> I noticed that the function above can be a bit simpler using TEST_DEV_ARRAY
> instead of TEST_DEV_ARRAY_SYSFS_DIRS. The patch below show it.
> 
> John, if you are okay with it, I will fold in the change below. Or if you want,
> I'm okay to keep your code as it is. Please let me know your thougths.

Yeah, it seems ok.

Let me know if you have a branch you want to test with all your changes.

Thanks

> 
> diff --git a/tests/md/003 b/tests/md/003
> index 83746ae..f4f35db 100755
> --- a/tests/md/003
> +++ b/tests/md/003
> @@ -22,24 +22,15 @@ device_requires() {
>   }
>   
>   test_device_array() {
> -	local test_dev
> -	local testdev_count=0
> -	declare -A NVME_TEST_DEVS_NAME
> -
>   	echo "Running md_atomics_test"
>   
> -	for test_dev in "${!TEST_DEV_ARRAY_SYSFS_DIRS[@]}"; do
> -		NVME_TEST_DEVS_NAME["$testdev_count"]="${test_dev##*/}"
> -		let testdev_count=testdev_count+1;
> -	done
> -
> -	if [[ $testdev_count -lt 4 ]]; then
> +	if [[ ${#TEST_DEV_ARRAY[@]} -lt 4 ]]; then
>   		SKIP_REASONS+=("requires at least 4 NVMe devices")
>   		return 1
>   	fi
>   
> -	_md_atomics_test "${NVME_TEST_DEVS_NAME[0]}" "${NVME_TEST_DEVS_NAME[1]}" \
> -			"${NVME_TEST_DEVS_NAME[2]}" "${NVME_TEST_DEVS_NAME[3]}"
> +	_md_atomics_test "${TEST_DEV_ARRAY[0]##*/}" "${TEST_DEV_ARRAY[1]##*/}" \
> +			 "${TEST_DEV_ARRAY[2]##*/}" "${TEST_DEV_ARRAY[3]##*/}"
>   
>   	echo "Test complete"
>   }