From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin@lichtvoll.de" <martin@lichtvoll.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH v11 0/7] block, scsi, md: Improve suspend and resume
Date: Thu, 9 Nov 2017 09:55:58 -0700 [thread overview]
Message-ID: <5e91482c-16f5-13c8-e42d-cbe8dda355ad@kernel.dk> (raw)
In-Reply-To: <1510246471.2608.11.camel@wdc.com>
On 11/09/2017 09:54 AM, Bart Van Assche wrote:
> On Thu, 2017-11-09 at 07:16 +0100, Oleksandr Natalenko wrote:
>> is this something known to you, or it is just my fault applying this series to
>> v4.13? Except having this warning, suspend/resume works for me:
>>
>> [ 27.383846] sd 0:0:0:0: [sda] Starting disk
>> [ 27.383976] sd 1:0:0:0: [sdb] Starting disk
>> [ 27.451218] sdb: Attempt to allocate non-preempt request in preempt-only
>> mode.
>> [ 27.459640] ------------[ cut here ]------------
>> [ 27.464521] WARNING: CPU: 0 PID: 172 at block/blk-core.c:823 blk_queue_enter+0x222/0x280
>
> Hello Oleksandr,
>
> Thanks for the testing. The warning that you reported is expected. Maybe it
> should be left out to avoid that users get confused.
If the warning is expected, then it should be removed. It'll just confuse
users and cause useless bug reports.
> Jens, this patch series still applies cleanly on top of your for-4.15/block
> branch. Are you fine with this patch series or do you perhaps want me to
> repost it with Oleksandr's Tested-by tag added to each patch?
Since you need to kill the warning anyway, let's get it respun.
--
Jens Axboe
next prev parent reply other threads:[~2017-11-09 16:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 22:41 [PATCH v11 0/7] block, scsi, md: Improve suspend and resume Bart Van Assche
2017-10-30 22:41 ` [PATCH v11 1/7] block: Make q_usage_counter also track legacy requests Bart Van Assche
2017-10-30 22:42 ` [PATCH v11 2/7] block: Introduce blk_get_request_flags() Bart Van Assche
2017-10-30 22:42 ` [PATCH v11 3/7] block: Introduce BLK_MQ_REQ_PREEMPT Bart Van Assche
2017-10-30 22:42 ` [PATCH v11 4/7] ide, scsi: Tell the block layer at request allocation time about preempt requests Bart Van Assche
2017-10-30 22:42 ` [PATCH v11 5/7] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag Bart Van Assche
2017-10-30 22:42 ` [PATCH v11 6/7] block, scsi: Make SCSI quiesce and resume work reliably Bart Van Assche
2017-10-30 22:42 ` [PATCH v11 7/7] block, nvme: Introduce blk_mq_req_flags_t Bart Van Assche
2017-11-09 6:16 ` [PATCH v11 0/7] block, scsi, md: Improve suspend and resume Oleksandr Natalenko
2017-11-09 16:54 ` Bart Van Assche
2017-11-09 16:55 ` Jens Axboe [this message]
2017-11-09 17:10 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e91482c-16f5-13c8-e42d-cbe8dda355ad@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=martin@lichtvoll.de \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).