From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE4616C850 for ; Thu, 18 Apr 2024 14:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713450619; cv=none; b=nw8xjVdo/RxKyrCpCRhr+nayHYNnE3Uk2kyDtl2zqf8eMbuD44OKvUtmbYhqimiLISJYI6MgvpsF4pyLEK9Ra9T9mjuU886keCt8kLHiiP28rLq8hKGJSQ8MLTU8ynOBnUee206cbRe19f+2BGH62JJCSkKvk2s9e+vPFsN8bZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713450619; c=relaxed/simple; bh=9/TQR1IEgTwqNlCPaqpr/Jnitj09THPvfGG3tVGKatE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cfj/1F3ZD2sYXBgyOORmXEOmtszbcDavQWCUxFtvwwsUqzPAgKQON2kHCzkxr1kXYqHAPjQTYYdL/gcCf1/u1HvaSsWMj/WVBNmzxBVBhXqi+uXlk+fYPKfRp0Ds0PeU8qkG1rTGHtS6QCvIve3uWC/HnZ4g7O+qI3fUlnCKhvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=zdD33CJz; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="zdD33CJz" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5f77c5350b3so40408a12.2 for ; Thu, 18 Apr 2024 07:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1713450616; x=1714055416; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s34+6Noa47tUC6nDFg281DMAoJ2FA4565ND1y1auC10=; b=zdD33CJzGPVBemwX8Vq2/tgYQv9NzMqDiUvkeXC9vxZGy13lqozfDI5sWnapncpxLp Qggkf8doo3qga/RF8pGt/E9DSnV8VMSV6T0LjLB/5er2gIs29NKrF5fi8UXsP5WDErgQ csxtzO0smFZkESrZlvdMZ4pxS++LWn9k0r/nm4jw0oF3pSgApuw6JGdZo5BA4WOHLu04 +qdraGIKYq0ugk/DqivMCln49aZ1KFL+4E5mM37iUpb9fD/eJXlqliVJ5V7lMZwKDU44 nXgF6SvthZb7E3URO5gmtWYDye7ysp/1BTQf6i9VCAb2FC3syS6eKnG97n5wl7rTPjov cJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713450616; x=1714055416; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s34+6Noa47tUC6nDFg281DMAoJ2FA4565ND1y1auC10=; b=cKUUNJKElhot1SgOdphlpL74nF/kZchtnU/s2InK0jmQI2u7zmXHzSAN5yqP6qABr5 9qpsGTv4v32S+qkjz/jVLAB/j6FAQHpO4pDt+7FheLcX3ERZd55+pADeF7sZeLh6GlXI JNoJo5cCcw83x71m9N0sv+HriAr1y2NaCQwkAW/ywLwj87lHKfEg0lZYj3+U8uHp371K TV126XmJmPqaQ7gkTiG2FruX4OX62ZGedWWjL1oOrazCOyn75I7P0GlGMnlD3C+jGTlX uYh7+a0WrSIydTaqw5ZPOz1/qT+2wYJxeDf+bqebQHhoec4ZiPagR/dg706IUd1/G2sE Qlkw== X-Forwarded-Encrypted: i=1; AJvYcCVyP/a6d+oVmJAXqxSLFD4HT7iUKDOrDyvTob6EeZYb6BS0U0y58pjTRPTyUbbh8GJCJL0353TArDXCZmbFd4G/2+nK5lvBbtAuwRI= X-Gm-Message-State: AOJu0Yw7CxB30OU5szFA3/lYTFw87aHTH990UshDMYDriIaurs7CEJwE Sr+7iKAAenocfKBjZzqXPbW805YtKc/63hAVNMnldCAoy1XIIPBSypW8egXHpjY= X-Google-Smtp-Source: AGHT+IE/r+6kGQWQgTrRuvZsXt5Jk/7zTOFdGOX/gMa9HL2erOx+JLXrmh+ZxfohkV9kQ/nVsaSU0A== X-Received: by 2002:a05:6a00:6013:b0:6ed:6944:b170 with SMTP id fo19-20020a056a00601300b006ed6944b170mr3128716pfb.1.1713450616403; Thu, 18 Apr 2024 07:30:16 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id v10-20020a62ac0a000000b006eadf879a30sm1578618pfe.179.2024.04.18.07.30.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 07:30:15 -0700 (PDT) Message-ID: <5f3d434b-e05c-445f-bee5-2bb1f11a5946@kernel.dk> Date: Thu, 18 Apr 2024 08:30:14 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] completion: move blk_wait_io to kernel/sched/completion.c To: Christoph Hellwig , Mikulas Patocka Cc: Peter Zijlstra , Mike Snitzer , Damien Le Moal , Ingo Molnar , Will Deacon , Waiman Long , Guangwu Zhang , dm-devel@lists.linux.dev, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <31b118f3-bc8d-b18b-c4b9-e57d74a73f@redhat.com> <20240417175538.GP40213@noisy.programming.kicks-ass.net> <546473fd-ca4b-3c64-349d-cc739088b748@redhat.com> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/17/24 10:57 PM, Christoph Hellwig wrote: > On Wed, Apr 17, 2024 at 08:00:22PM +0200, Mikulas Patocka wrote: >>>> +EXPORT_SYMBOL(wait_for_completion_long_io); >>> >>> Urgh, why is it a sane thing to circumvent the hang check timer? >> >> The block layer already does it - the bios can have arbitrary size, so >> waiting for them takes arbitrary time. > > And as mentioned the last few times around, I think we want a task > state to say that task can sleep long or even forever and not propagate > this hack even further. It certainly is a hack/work-around, but unless there are a lot more that should be using something like this, I don't think adding extra core complexity in terms of a special task state (or per-task flag, at least that would be easier) is really warranted. -- Jens Axboe