From: Jens Axboe <axboe@kernel.dk>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: martin.petersen@oracle.com, tom.leiming@gmail.com, hch@lst.de,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] block: fix the DISCARD request merge
Date: Mon, 29 Oct 2018 09:33:19 -0600 [thread overview]
Message-ID: <610adbc6-24ba-e6ed-a98a-f3faeef8bd51@kernel.dk> (raw)
In-Reply-To: <1540641134-21485-1-git-send-email-jianchao.w.wang@oracle.com>
On 10/27/18 5:52 AM, Jianchao Wang wrote:
> There are two cases when handle DISCARD merge.
> If max_discard_segments == 1, the bios/requests need to be contiguous
> to merge. If max_discard_segments > 1, it takes every bio as a range
> and different range needn't to be contiguous.
>
> But now, attempt_merge screws this up. It always consider contiguity
> for DISCARD for the case max_discard_segments > 1 and cannot merge
> contiguous DISCARD for the case max_discard_segments == 1, because
> rq_attempt_discard_merge always returns false in this case.
> This patch fixes both of the two cases above.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-10-29 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 11:52 [PATCH V5] block: fix the DISCARD request merge Jianchao Wang
2018-10-28 15:48 ` Christoph Hellwig
2018-10-29 9:44 ` Ming Lei
2018-10-29 15:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610adbc6-24ba-e6ed-a98a-f3faeef8bd51@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox