linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Yi Zhang <yi.zhang@redhat.com>,
	linux-nvme@lists.infradead.org,
	linux-block <linux-block@vger.kernel.org>
Cc: axboe@kernel.dk, Rachel Sibley <rasibley@redhat.com>,
	CKI Project <cki-project@redhat.com>,
	Chaitanya.Kulkarni@wdc.com
Subject: Re: kernel null pointer at nvme_tcp_init_iter+0x7d/0xd0 [nvme_tcp]
Date: Mon, 8 Feb 2021 10:42:28 -0800	[thread overview]
Message-ID: <6147d452-a12e-c76c-22f1-5d9e7cb6b01d@grimberg.me> (raw)
In-Reply-To: <af1d7e9d-0170-82f6-30e1-01f045d73fc7@grimberg.me>


>> Hi Sagi
>>
>> On 2/8/21 5:46 PM, Sagi Grimberg wrote:
>>>
>>>> Hello
>>>>
>>>> We found this kernel NULL pointer issue with latest 
>>>> linux-block/for-next and it's 100% reproduced, let me know if you 
>>>> need more info/testing, thanks
>>>>
>>>> Kernel repo: 
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>> Commit: 11f8b6fd0db9 - Merge branch 'for-5.12/io_uring' into for-next
>>>>
>>>> Reproducer: blktests nvme-tcp/012
>>>
>>> Thanks for reporting Ming, I've tried to reproduce this on my VM
>>> but did not succeed. Given that you have it 100% reproducible,
>>> can you try to revert commit:
>>>
>>> 0dc9edaf80ea nvme-tcp: pass multipage bvec to request iov_iter
>>>
>>
>> Revert this commit fixed the issue and I've attached the config. :)
> 
> Good to know,
> 
> I see some differences that I should probably change to hit this:
> -- 
> @@ -254,14 +256,15 @@ CONFIG_PERF_EVENTS=y
>   # end of Kernel Performance Events And Counters
> 
>   CONFIG_VM_EVENT_COUNTERS=y
> +CONFIG_SLUB_DEBUG=y
>   # CONFIG_COMPAT_BRK is not set
> -CONFIG_SLAB=y
> -# CONFIG_SLUB is not set
> -# CONFIG_SLOB is not set
> -CONFIG_SLAB_MERGE_DEFAULT=y
> -# CONFIG_SLAB_FREELIST_RANDOM is not set
> +# CONFIG_SLAB is not set
> +CONFIG_SLUB=y
> +# CONFIG_SLAB_MERGE_DEFAULT is not set
> +CONFIG_SLAB_FREELIST_RANDOM=y
>   # CONFIG_SLAB_FREELIST_HARDENED is not set
> -# CONFIG_SHUFFLE_PAGE_ALLOCATOR is not set
> +CONFIG_SHUFFLE_PAGE_ALLOCATOR=y
> +CONFIG_SLUB_CPU_PARTIAL=y
>   CONFIG_SYSTEM_DATA_VERIFICATION=y
>   CONFIG_PROFILING=y
>   CONFIG_TRACEPOINTS=y
> @@ -299,7 +302,8 @@ CONFIG_HAVE_INTEL_TXT=y
>   CONFIG_X86_64_SMP=y
>   CONFIG_ARCH_SUPPORTS_UPROBES=y
>   CONFIG_FIX_EARLYCON_MEM=y
> -CONFIG_PGTABLE_LEVELS=4
> +CONFIG_DYNAMIC_PHYSICAL_MASK=y
> +CONFIG_PGTABLE_LEVELS=5
>   CONFIG_CC_HAS_SANE_STACKPROTECTOR=y
> -- 
> 
> Probably CONFIG_SLUB and CONFIG_SLUB_DEBUG should be used.

Used your profile and this still does not happen :(

  reply	other threads:[~2021-02-08 18:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cki.F3E139361A.EN5MUSJKK9@redhat.com>
2021-02-06  3:08 ` kernel null pointer at nvme_tcp_init_iter+0x7d/0xd0 [nvme_tcp] Yi Zhang
2021-02-07  4:50   ` kernel null pointer at nvme_tcp_init_iter[nvme_tcp] with blktests nvme-tcp/012 Yi Zhang
2021-02-07  5:25     ` Chaitanya Kulkarni
2021-02-08  6:48       ` Yi Zhang
2021-02-07  5:48     ` Chaitanya Kulkarni
2021-02-07  5:58     ` Chaitanya Kulkarni
2021-02-07  7:14   ` kernel null pointer at nvme_tcp_init_iter+0x7d/0xd0 [nvme_tcp] Chaitanya Kulkarni
2021-02-08  9:53     ` Sagi Grimberg
2021-02-08  9:46   ` Sagi Grimberg
     [not found]     ` <5848858e-239d-acb2-fa24-c371a3360557@redhat.com>
2021-02-08 17:54       ` Sagi Grimberg
2021-02-08 18:42         ` Sagi Grimberg [this message]
2021-02-09  4:21           ` Ming Lei
2021-02-09  7:21             ` Sagi Grimberg
2021-02-09  7:50               ` Ming Lei
2021-02-09  8:34                 ` Chaitanya Kulkarni
2021-02-09 10:09                   ` Sagi Grimberg
2021-02-09 10:07                 ` Sagi Grimberg
2021-02-09 10:33                   ` Ming Lei
2021-02-09 10:36                     ` Sagi Grimberg
2021-02-09 10:25       ` Sagi Grimberg
2021-02-09 12:57         ` Yi Zhang
2021-02-09 18:01           ` Sagi Grimberg
2021-02-10  2:51             ` Yi Zhang
2021-02-10  3:38               ` Keith Busch
2021-02-10  5:03               ` Chaitanya Kulkarni
2021-02-10 22:06                 ` Sagi Grimberg
2021-02-10 22:15                   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6147d452-a12e-c76c-22f1-5d9e7cb6b01d@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=cki-project@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=rasibley@redhat.com \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).