From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>, Omar Sandoval <osandov@fb.com>
Cc: linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] blk-mq: Add a NULL check in blk_mq_free_map_and_requests()
Date: Thu, 29 Nov 2018 08:17:20 -0700 [thread overview]
Message-ID: <6224d24a-a04c-ccdc-6adc-23da4d10eaa7@kernel.dk> (raw)
In-Reply-To: <20181129105654.5icpvxx7p2kq257c@kili.mountain>
On 11/29/18 3:56 AM, Dan Carpenter wrote:
> I recently found some code which called blk_mq_free_map_and_requests()
> with a NULL set->tags pointer. I fixed the caller, but it seems like a
> good idea to add a NULL check here as well. Now we can call:
>
> blk_mq_free_tag_set(set);
> blk_mq_free_tag_set(set);
>
> twice in a row and it's harmless.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-29 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:55 [PATCH 1/2] ataflop: fix error handling in atari_floppy_init() Dan Carpenter
2018-11-29 10:56 ` [PATCH 2/2] blk-mq: Add a NULL check in blk_mq_free_map_and_requests() Dan Carpenter
2018-11-29 15:17 ` Jens Axboe [this message]
2018-11-29 15:17 ` [PATCH 1/2] ataflop: fix error handling in atari_floppy_init() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6224d24a-a04c-ccdc-6adc-23da4d10eaa7@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).