From: Jens Axboe <axboe@kernel.dk>
To: weiping zhang <zhangweiping@didichuxing.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-mq: remove unused function hctx_allow_merges
Date: Sat, 30 Sep 2017 10:16:38 +0200 [thread overview]
Message-ID: <63663207-1f6a-31c8-210d-3df99c46a4f5@kernel.dk> (raw)
In-Reply-To: <fb885765-3243-15ee-da3c-272e0a2d3cc5@kernel.dk>
On 09/30/2017 10:15 AM, Jens Axboe wrote:
> On 09/30/2017 09:01 AM, weiping zhang wrote:
>> since 9bddeb2a5b981 "blk-mq: make per-sw-queue bio merge as default .bio_merge"
>> there is no caller for this function.
>
> Looks like this should change the new check to actually use this function
> instead, or we will be doing merges if someone has turned off merging
> through the sysfs 'nomerges' function.
Actually, looks like the caller does that now, so the patch was actually
fine.
--
Jens Axboe
prev parent reply other threads:[~2017-09-30 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 7:01 [PATCH] blk-mq: remove unused function hctx_allow_merges weiping zhang
2017-09-30 7:53 ` Ming Lei
2017-09-30 8:15 ` Jens Axboe
2017-09-30 8:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63663207-1f6a-31c8-210d-3df99c46a4f5@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox