From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D85C35240 for ; Fri, 24 Jan 2020 00:49:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79543214AF for ; Fri, 24 Jan 2020 00:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729847AbgAXAtZ (ORCPT ); Thu, 23 Jan 2020 19:49:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:57792 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729762AbgAXAtZ (ORCPT ); Thu, 23 Jan 2020 19:49:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 844CFAD10; Fri, 24 Jan 2020 00:49:23 +0000 (UTC) Subject: Re: [PATCH 14/17] bcache: back to cache all readahead I/Os To: Jens Axboe Cc: Michael Lyle , linux-bcache , linux-block@vger.kernel.org, stable References: <20200123170142.98974-1-colyli@suse.de> <20200123170142.98974-15-colyli@suse.de> <31f7f6b4-98ea-3cf6-44cc-a9ba67484eb0@kernel.dk> From: Coly Li Organization: SUSE Labs Message-ID: <6373da22-9dc1-9525-4048-2c533407c917@suse.de> Date: Fri, 24 Jan 2020 08:49:20 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <31f7f6b4-98ea-3cf6-44cc-a9ba67484eb0@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020/1/24 2:31 上午, Jens Axboe wrote: > On 1/23/20 10:27 AM, Coly Li wrote: >> On 2020/1/24 1:19 上午, Michael Lyle wrote: >>> Hi Coly and Jens-- >>> >>> One concern I have with this is that it's going to wear out >>> limited-lifetime SSDs a -lot- faster. Was any thought given to making >>> this a tunable instead of just changing the behavior? Even if we have >>> an anecdote or two that it seems to have increased performance for >>> some workloads, I don't expect it will have increased performance in >>> general and it may even be costly for some workloads (it all comes >>> down to what is more useful in the cache-- somewhat-recently readahead >>> data, or the data that it is displacing). >> >> Hi Mike, >> >> Copied. This is good suggestion, I will do it after I back from Lunar >> New Year vacation, and submit it with other tested patches in following >> v5.6-rc versions. > > Do you want me to just drop this patch for now from the series? > Hi Jens, OK, please drop this patch from this series. I will re-submit the patch with sysfs interface later with other patches. Thanks. -- Coly Li